1. 14 Apr, 2017 11 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #43939 from FengyunPan/remove-nameIndexFunc · 113606cb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44424, 44026, 43939, 44386, 42914)
      
      ServiceAccountsController does not need nameIndexFunc to index ST
      
      The ServiceAccountsController's Informer does not need nameIndexFunc.
      113606cb
    • Kubernetes Submit Queue's avatar
      Merge pull request #44026 from nikinath/precision-json · 9ef911ed
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44424, 44026, 43939, 44386, 42914)
      
      Preserve int data when unmarshalling for TPR
      
      **What this PR does / why we need it**:
      
      The Go json package converts all numbers to float64 while unmarshalling.
      This exposes many of the int64 fields to corruption when marshalled back to json.
      
      The json package provided by kubernetes also provides a way to defer conversion of numbers
      (https://golang.org/pkg/encoding/json/#Decoder.UseNumber) and does the conversions to int or float.
      
      This is also implemented in the custom json package. See:
      (https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/util/json/json.go)
      
      Now, the number is preserved as an integer till the highest int64 number - `9223372036854775807`.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #30213
      
      **Special notes for your reviewer**: See also https://github.com/kubernetes/kubernetes/pull/16964
      
      **Release note**:
      
      ```
      NONE
      ```
      9ef911ed
    • Kubernetes Submit Queue's avatar
      Merge pull request #44424 from timothysc/in-cluster-config-e2e · 09fec90f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44424, 44026, 43939, 44386, 42914)
      
      Try in cluster config when input KubeConfig is empty
      
      **What this PR does / why we need it**:
      Allows for downstream providers to run e2es "incluster" sans kubeconfig
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```
      NONE
      ```
      
      /cc @kubernetes/sig-testing-pr-reviews @marun
      09fec90f
    • Kubernetes Submit Queue's avatar
      Merge pull request #43457 from timothysc/storage_e2e_split · ad964e71
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Segregate storage e2es for easier assignment and dep isolation.
      
      **What this PR does / why we need it**:
      Follow on from slack conversations to isolate storage deps and have easier assignment of e2es.
      
      As of today there is general consensus that the e2es need to be broken apart, this is 1st iteration on the sig-storage test splitting.  Follow on work is needed here.   
      
      **Release note**:
      
      ```
      NONE
      ```
      
      /cc @saad-ali @kubernetes/sig-storage-pr-reviews @kubernetes/sig-testing-pr-reviews
      ad964e71
    • Kubernetes Submit Queue's avatar
      Merge pull request #44299 from caesarxuchao/move-ref.go · ab22baf9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44406, 41543, 44071, 44374, 44299)
      
      Move pkg/api/ref.go to a subpackage
      
      First commit is #44296. (unfortunately, removing that commit results in conflicts)
      
      This PR moves the pkg/api/ref.go to its own subpackage. It's mostly a mechanic move.
      
      I'll send a few more PRs to make the k8s.io/kubernetes/pkg/api package only contains the code we want in the k8s.io/api repo, then we can run a [script](https://github.com/kubernetes/kubernetes/pull/41747/commits/a0015fd1be6c6a239fc40cc3c04ba5ed7b1ab22e#diff-7a2fbb4371972350ee414c6b88aee1c8) to cut the new repo.
      ab22baf9
    • Kubernetes Submit Queue's avatar
      Merge pull request #44374 from FengyunPan/fix-disruptionevent · 7ae36bf8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44406, 41543, 44071, 44374, 44299)
      
      Record a warning type event
      
      A warning type event should be recorded when failed to calculate
      the number of expected pods.
      7ae36bf8
    • Kubernetes Submit Queue's avatar
      Merge pull request #44071 from liggitt/service-account-lookup · 08bd9c77
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44406, 41543, 44071, 44374, 44299)
      
      Enable service account token lookup by default
      
      Fixes #24167
      
      ```release-note
      kube-apiserver: --service-account-lookup now defaults to true, requiring the Secret API object containing the token to exist in order for a service account token to be valid. This enables service account tokens to be revoked by deleting the Secret object containing the token.
      ```
      08bd9c77
    • Kubernetes Submit Queue's avatar
      Merge pull request #41543 from dshulyak/decouple_remotecommand · 4653a9b2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44406, 41543, 44071, 44374, 44299)
      
      Decouple remotecommand
      
      Refactored unversioned/remotecommand to decouple it from undesirable dependencies:
      
      - term package now is not required, and functionality required to resize terminal size can be plugged in directly in kubectl
      - in order to remove dependency on kubelet package - constants from kubelet/server/remotecommand were moved to separate util package (pkg/util/remotecommand)
      - remotecommand_test.go moved to pkg/client/tests module
      4653a9b2
    • Kubernetes Submit Queue's avatar
      Merge pull request #44406 from Random-Liu/stop-following-when-exited · 1cf6ef08
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      CRI: Stop following container log when container exited.
      
      Fixes https://github.com/kubernetes/kubernetes/issues/44340.
      
      This PR changed kubelet to periodically check whether container is running when following container logs, and stop following when container exited.
      
      I've tried this PR in my local cluster:
      ```
      Wed Apr 12 20:23:54 UTC 2017
      Wed Apr 12 20:23:58 UTC 2017
      Wed Apr 12 20:24:02 UTC 2017
      Wed Apr 12 20:24:06 UTC 2017
      Wed Apr 12 20:24:10 UTC 2017
      Wed Apr 12 20:24:14 UTC 2017
      Wed Apr 12 20:24:18 UTC 2017
      Wed Apr 12 20:24:22 UTC 2017
      Wed Apr 12 20:24:26 UTC 2017
      Wed Apr 12 20:24:30 UTC 2017
      Wed Apr 12 20:24:34 UTC 2017
      Wed Apr 12 20:24:38 UTC 2017
      Wed Apr 12 20:24:42 UTC 2017
      Wed Apr 12 20:24:46 UTC 2017
      failed to wait logs for log file "/var/log/pods/1d54634c7b31346fc3219f5e0b7507cc/nginx_0.log": container "b9a17a2c53550c3703ab350d85911743af8bf164a41813544fd08fb9585f7501" is not running (state="CONTAINER_EXITED")
      ```
      
      The only difference is that `ReadLogs` will return error when container exits during following. I'm not sure whether we should get rid of it or not.
      
      @yujuhong @feiskyer @JorritSalverda
      /cc @kubernetes/sig-node-bugs 
      
      **Release note**:
      ```release-note
      `kubectl logs -f` now stops following when container stops.
      ```
      1cf6ef08
    • Kubernetes Submit Queue's avatar
      Merge pull request #44432 from harryge00/fix-typos · b4c76c6a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fix typos and update an outdated reference in persistent-volume-provi…
      
      …sioning README
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      b4c76c6a
    • Kubernetes Submit Queue's avatar
      Merge pull request #43199 from jorenhehe/labels-typos · b7ed2d11
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fix typos
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      b7ed2d11
  2. 13 Apr, 2017 29 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #44434 from netroby/pr/fix-trouble · 3328ab1b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Adjust the link to the right troubleshooting doc page
      
      see #3366
      
      https://github.com/kubernetes/kubernetes.github.io/issues/3366
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      3328ab1b
    • Kubernetes Submit Queue's avatar
      Merge pull request #43942 from wanghaoran1988/fix_43323 · 9f92832f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44447, 44456, 43277, 41779, 43942)
      
      Clean up pre-ControllerRef compatibility logic
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #43323 
      
      **Special notes for your reviewer**:
      No
      **Release note**:
      
      ```
      NONE
      ```
      9f92832f
    • Kubernetes Submit Queue's avatar
      Merge pull request #41779 from StudyNick/zte-20170221 · 1dcb2881
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44447, 44456, 43277, 41779, 43942)
      
      'workqueue' modify 'work queue'
      1dcb2881
    • Kubernetes Submit Queue's avatar
      Merge pull request #43277 from StudyNick/zte-20170315 · d32668b0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44447, 44456, 43277, 41779, 43942)
      
      variable 'controller' collides with imported package name
      
      variable 'controller' collides with imported package name,
       'controller'  modify 'ctrl'
      d32668b0
    • Kubernetes Submit Queue's avatar
      Merge pull request #44456 from mbruzek/e2e-update · ef2edcc9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fixing the kubernetes-e2e charm README to use the containers namespace.
      
      **What this PR does / why we need it**: The deploy command is not correct in the README.
      
      **Which issue this PR fixes**: fixes https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/251
      
      **Special notes for your reviewer**: This is a text based change to the kubernetes-e2e charm README
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      A user pointed out the instructions in the kubernetes-e2e README were incorrect. Fixing that.
      ef2edcc9
    • Kubernetes Submit Queue's avatar
      Merge pull request #44447 from piosz/logging-e2e · b75a0169
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Harden requirements for lost logs in GCL e2e load tests
      
      cc @crassirostris
      b75a0169
    • Kubernetes Submit Queue's avatar
      Merge pull request #42144 from xilabao/add-resource-validate · d2733394
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      add validate to resource in can-i
      
      ```
      #kubectl auth can-i get xxx
      the server doesn't have a resource type "xxx"
      ```
      d2733394
    • Random-Liu's avatar
      2fbf34f7
    • Matt Bruzek's avatar
      7f3f05e1
    • Chao Xu's avatar
      move ref.go to its own subpackage · d9920c53
      Chao Xu authored
      d9920c53
    • Kubernetes Submit Queue's avatar
      Merge pull request #44251 from superbrothers/completion-cluster-user-flags · c3463d73
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Support completion for --cluster and --user
      
      **What this PR does / why we need it**:
      
      kubectl is supported completion for `--cluster` and `--user`.
      
      ```
      $ kubectl --user=<tab>
      --user=minikube  --user=user01
      
      $ kubectl --cluster=<tab>
      --cluster=cluster01  --cluster=minikube
      ```
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Add completion support for --namespace and --cluster to kubectl
      ```
      c3463d73
    • Kubernetes Submit Queue's avatar
      Merge pull request #42302 from wanghaoran1988/add_test · 9c730b57
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add a test scenario for default node slector
      9c730b57
    • Piotr Szczesniak's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #44185 from janetkuo/1.6-changelog-fix · 84dbf9c8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix some links in CHANGELOG
      84dbf9c8
    • Kubernetes Submit Queue's avatar
      Merge pull request #41659 from jeffvance/kubelet-wedge2 · b0a72417
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      add kubelet tests to verify host clean up
      
      **What this PR does / why we need it**:
      Increasingly we're seeing more failures in persistent volume e2e tests where pv tests are run in parallel with disruptive tests. The quick solution is to tag the pv tests as Flaky. This pr addresses one cause of the flakiness and adds a disruptive kubelet test.
      Once this pr is shown to not produce flakes the [Flaky] tag for the "HostCleanup" tests will be removed in a separate pr.
      + Adds volume tests to _kubelet.go_ motivated by issues [31272](https://github.com/kubernetes/kubernetes/issues/31272) and [37657](https://github.com/kubernetes/kubernetes/issues/37657)
      + Addresses  reverted pr [41178](https://github.com/kubernetes/kubernetes/pull/41178) and negates the need for pr [41229](https://github.com/kubernetes/kubernetes/pull/41229)
      
      **Which issue this PR fixes** 
      Adds regression tests to cover issues: #31272 and #37657
      
      **Special notes for your reviewer**:
      It's possible that one of the new tests, which relies on the existence of _/usr/sbin/rpc.nfsd_ in the nfs-server pod, will not work in the GCI container env. If this turns out to be true then I will add a `SkipIfProviderIs("gke")` to the `It` block.
      
      **Release note**:
      ```release-note
      NONE
      ```
      b0a72417
    • Dmitry Shulyak's avatar
      Decouple remotecommand client from term/kubelet dependencies · f50480c7
      Dmitry Shulyak authored
      In order to move client/unversioned/remotecommand to client-go as a followup
      for this change we have to decouple it from tons of dependencies
      f50480c7
    • Kubernetes Submit Queue's avatar
      Merge pull request #44416 from ivan4th/fix-kubectl-crash · 45dc1539
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix crash in kubectl run
      
      I observed the problem in k8s 1.5.1, but the code is still there, so fixing it.
      Here's the old backtrace - happened due to network disconnection during `kubectl run`:
      
      ```
      ivan4th@i4mac:~$ kubectl run --rm -it alpine1 --image=alpine:3.5 --restart=Never /bin/sh
      Waiting for pod default/alpine1 to be running, status is Pending, pod ready: false
      If you don't see a command prompt, try pressing enter.
      / # panic: runtime error: invalid memory address or nil pointer dereference
      [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0xe8706]
      
      goroutine 1 [running]:
      panic(0x11e0d80, 0xc420016090)
              /usr/local/go/src/runtime/panic.go:500 +0x1a1
      k8s.io/kubernetes/pkg/kubectl/cmd.waitForPod.func2(0xc400000008, 0x14783a0)
              /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/kubectl/cmd/run.go:432 +0x126
      k8s.io/kubernetes/pkg/util/interrupt.(*Handler).Run(0xc420379230, 0xc4206c11f0, 0x0, 0x0)
              /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/interrupt/interrupt.go:103 +0x109
      k8s.io/kubernetes/pkg/kubectl/cmd.waitForPod(0x208c8c0, 0xc4204832c0, 0xc4204395d0, 0x7, 0xc4204395a0, 0x7, 0x1477e10, 0xc4206e6040, 0x0, 0x0, ...)
              /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/kubectl/cmd/run.go:434 +0x49e
      k8s.io/kubernetes/pkg/kubectl/cmd.waitForPodTerminated(0x208c8c0, 0xc4204832c0, 0xc4204395d0, 0x7, 0xc4204395a0, 0x7, 0x1c48020, 0xc42002c010, 0xc420124300, 0x0, ...)
              /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/kubectl/cmd/run.go:458 +0xea
      k8s.io/kubernetes/pkg/kubectl/cmd.Run(0x1c61040, 0xc4203106e0, 0x1c47fe0, 0xc42002c008, 0x1c48020, 0xc42002c010, 0x1c48020, 0xc42002c018, 0xc42047e6c0, 0xc42006d200, ...)
              /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/kubectl/cmd/run.go:304 +0xe37
      k8s.io/kubernetes/pkg/kubectl/cmd.NewCmdRun.func1(0xc42047e6c0, 0xc42006d200, 0x2, 0x6)
              /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/kubectl/cmd/run.go:98 +0x144
      k8s.io/kubernetes/vendor/github.com/spf13/cobra.(*Command).execute(0xc42047e6c0, 0xc42006d140, 0x6, 0x6, 0xc42047e6c0, 0xc42006d140)
              /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/github.com/spf13/cobra/command.go:603 +0x439
      k8s.io/kubernetes/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc4204dbb00, 0xc420438e50, 0x1, 0x1)
              /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/github.com/spf13/cobra/command.go:689 +0x367
      k8s.io/kubernetes/vendor/github.com/spf13/cobra.(*Command).Execute(0xc4204dbb00, 0xc4203106e0, 0x1c47fe0)
              /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/github.com/spf13/cobra/command.go:648 +0x2b
      k8s.io/kubernetes/cmd/kubectl/app.Run(0x0, 0x0)
              /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/cmd/kubectl/app/kubectl.go:38 +0xd5
      main.main()
              /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/cmd/kubectl/kubectl.go:26 +0x22
      ```
      45dc1539
    • Kubernetes Submit Queue's avatar
      Merge pull request #44002 from mikedanese/vers-apiserver · cacfd756
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      kubeadm: don't add proxy flag to apiservers below v1.7
      cacfd756
    • Kubernetes Submit Queue's avatar
      Merge pull request #44399 from deads2k/server-19-deregister · a9019fe1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      add deregistration for paths
      
      Aggregation and TPRs require the ability to de-register endpoints.  This adds the capability and makes it threadsafe.
      a9019fe1
    • Kubernetes Submit Queue's avatar
      Merge pull request #43297 from mvdan/kubectl-params · 19d72267
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      kubectl/cmd: remove a bunch of unused parameters
      
      Found with github.com/mvdan/unparam.
      
      **Release note**: NONE
      19d72267
    • Kubernetes Submit Queue's avatar
      Merge pull request #42663 from soltysh/37166_followup · 868eb745
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add default information to CronJobSpec
      
      This is requested followup to https://github.com/kubernetes/kubernetes/pull/41890
      
      @smarterclayton @janetkuo ptal
      868eb745
    • Kubernetes Submit Queue's avatar
      Merge pull request #44397 from MrHohn/e2e-service-source-ip-timeout · a820e7bc
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      [e2e] Bump up pod deletion time for source pod IP test
      
      From #44225.
      
      Source pod IP e2e test is pretty flaky lately, and most of the failures seem to be timeout waiting for pod "kube-proxy-mode-detector" to disappear. Didn't found any other thing suspicious.
      
      This PR bumps pod deletion timeout to DefaultPodDeletionTimeout, which is 3 minutes. Hopefully it will mitigate the flakes.
      
      /assign @freehan 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      a820e7bc
    • Kubernetes Submit Queue's avatar
      Merge pull request #44378 from FengyunPan/update-federation-event · 5c94d422
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Use EventTypeWarning instead of EventTypeNormal when failure
      5c94d422
    • ZhiFeng Hu's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #44396 from wongma7/etcd-version · c814bab9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Do etcd semver validation using posix only
      
      this is a follow-up to https://github.com/kubernetes/kubernetes/pull/44352, can't use sort -V because not everybody has that
      ```release-note
      NONE
      ```
      c814bab9
    • Kubernetes Submit Queue's avatar
      Merge pull request #43183 from netroby/pr/wordpress-4.7.3 · 7a20c565
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      upgrade wordpress to 4.7.3 latest
      
      see https://github.com/kubernetes/kubernetes/pull/42029
      
      /release-note-none
      7a20c565
    • Kubernetes Submit Queue's avatar
      Merge pull request #44379 from guangyouyu/garyyu_master · 7f0004de
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Bugfix: cloud-controller-manager routeController.run() block in WaitForCacheSync
      
      **What this PR does / why we need it**:
      cloud-controller-manager routeController.run not run in goroutine will block to  wait nodeListerSynced because sharedInformers not started
      
      
      **Special notes for your reviewer**:
      
      cloud-controller-manager routeController.run  should run in goroutine like the same code in kube-controller-manager,or it will block to  wait nodeListerSynced,but sharedInformers not startd.
      
      ```go
      //controller-manager.go:197
      func StartControllers(s *options.CloudControllerManagerServer, kubeconfig *restclient.Config, rootClientBuilder, clientBuilder controller.ControllerClientBuilder, stop <-chan struct{}, recorder record.EventRecorder, cloud cloudprovider.Interface) error {
      	// Function to build the kube client object
      	client := func(serviceAccountName string) clientset.Interface {
      		return rootClientBuilder.ClientOrDie(serviceAccountName)
      	}
      	versionedClient := client("shared-informers")
      	sharedInformers := informers.NewSharedInformerFactory(versionedClient, resyncPeriod(s)())
      ocateNodeCIDRs && s.ConfigureCloudRoutes {
      		if routes, ok := cloud.Routes(); !ok {
      			glog.Warning("configure-cloud-routes is set, but cloud provider does not support routes. Will not configure cloud provider routes.")
      		} else {
      			routeController := routecontroller.New(routes, client("route-controller"), sharedInformers.Core().V1().Nodes(), s.ClusterName, clusterCIDR)
                             //should run in goroutine
      ----->		routeController.Run(stop, s.RouteReconciliationPeriod.Duration)
      			time.Sleep(wait.Jitter(s.ControllerStartInterval.Duration, ControllerStartJitter))
      		}
      	} else {
      		glog.Infof("Will not configure cloud provider routes for allocate-node-cidrs: %v, configure-cloud-routes: %v.", s.AllocateNodeCIDRs, s.ConfigureCloudRoutes)
      	}
      
      ---> 	sharedInformers.Start(stop)
      
      	select {}
      }
      
      
      
      //routecontroller.go:77
      func (rc *RouteController) Run(stopCh <-chan struct{}, syncPeriod time.Duration) {
      	defer utilruntime.HandleCrash()
      
      	glog.Info("Starting the route controller")
             //will block
      --->   	if !cache.WaitForCacheSync(stopCh, rc.nodeListerSynced) {
      		utilruntime.HandleError(fmt.Errorf("timed out waiting for caches to sync"))
      		return
      	}
      
      	go wait.NonSlidingUntil(func() {
      		if err := rc.reconcileNodeRoutes(); err != nil {
      			glog.Errorf("Couldn't reconcile node routes: %v", err)
      		}
      	}, syncPeriod, wait.NeverStop)
      }
      ```
      7f0004de
    • Kubernetes Submit Queue's avatar
      Merge pull request #44391 from ncdc/reduce-rc-logging · e4752d61
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Reduce replication_controller log spam
      
      Decrease verbosity and reword 'Observed updated replication controller
      ...' now that the issue it was added for has been fixed.
      
      This was originally added to debug #31981, and it was fixed back in September 2016.
      
      cc @gmarek @wojtek-t @kargakis @eparis @smarterclayton
      e4752d61
    • haoyuan's avatar