- 04 Sep, 2018 8 commits
-
-
stewart-yu authored
[kube-controller-manager] fix some reference from cmd/*-controller-manager about kubeControllerManagerConfiguration
-
stewart-yu authored
[kube-controller-manager] fix some reference from pkg/apis/componentconfig about kube-controller-manager api
-
stewart-yu authored
-
stewart-yu authored
[kube-controller-manager] just only remove struct and default about KubeControllerManagerConfiguration from pkg/apis/componentconfig
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Replace scale down window **What this PR does / why we need it**: Replace scale down forbidden window with scale down stabilization window. This allows scale down based on more than one sample, to avoid rapidly changing size up and down for controllers with fluctuating load. A bit more in https://docs.google.com/document/d/1IdG3sqgCEaRV3urPLA29IDudCufD89RYCohfBPNeWIM This PR is copy of #67771 with resolved comments. **Release note**: ```release-note Replace scale down forbidden window with scale down stabilization window. Rather than waiting a fixed period of time between scale downs HPA now scales down to the highest recommendation it during the scale down stabilization window. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 68135, 68188). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md . Fixup openstack cloud provider loadbalancer deletion error This change enables ```getLoadBalancer``` to return the loadbalancer even if no floating ip is associated to the VIP port of the loadbalancer. Signed-off-by:
Eunsoo Park <esevan.park@gmail.com> **What this PR does / why we need it**: This PR fixes the bug like below. ``` Warning CreatingLoadBalancerFailed 17m (x3445 over 12d) service-controller Error creating load balancer (will retry): error getting LB for service default/influxdb: error getting floating ip for port 81253cae-acd6-4bed-8006-814c8729be8c: failed to find object ``` **Special notes for your reviewer**: Refer to following bug description for better understanding of this PR. When k8s service type is changed from LoadBalancer to others, there's a deleting loadbalancer process in kubernetes cloud provider as below. https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/service/service_controller.go#L284 ``` if !wantsLoadBalancer(service) { _, exists, err := s.balancer.GetLoadBalancer(context.TODO(), s.clusterName, service) if err != nil { return fmt.Errorf("error getting LB for service %s: %v", key, err) } if exists { glog.Infof("Deleting existing load balancer for service %s that no longer needs a loadbalancer.", key) s.eventRecorder.Event(service, v1.EventTypeNormal, "DeletingLoadBalancer", "Deleting loadbalancer") if err := s.balancer.EnsureLoadBalancerDeleted(context.TODO(), s.clusterName, service); err != nil { return err } s.eventRecorder.Event(service, v1.EventTypeNormal, "DeletedLoadBalancer", "Deleted loadbalancer") } ``` Openstack cloud provider returns error even though LB exists since there's no associated floating IP with VIP port. https://github.com/kubernetes/kubernetes/blob/master/pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go#L476 ``` floatIP, err := getFloatingIPByPortID(lbaas.network, portID) if err != nil { return nil, false, fmt.Errorf("error getting floating ip for port %s: %v", portID, err) } ``` This caused ```GetLoadBalancer()``` failed and retrying over and over in ```processServiceUpdate``` of ```k8sServiceController```. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Use random backoff for retries in cloud-cidr-allocator Ref https://github.com/kubernetes/kubernetes/pull/68084#issuecomment-417651247 /cc @wojtek-t ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Add validation for kube-scheduler configuration options **What this PR does / why we need it**: This adds validation to the kube-scheduler so that we're not accepting bogus values to the kube-scheduler. As requested by @bsalamat in issue https://github.com/kubernetes/kubernetes/issues/66743 **Which issue(s) this PR fixes**: Fixes #66743 **Special notes for your reviewer**: - Not sure if this validation is too heavy handed. Would love some feedback. - I started working on this before I realized @islinwb was also working on this same problem... https://github.com/kubernetes/kubernetes/pull/66787 I put this PR up anyways since I'm sure good code exists in both. I wasn't aware of the /assign command so didn't assign myself before starting work. - I didn't have time to work on adding validation to deprecated cli options. If the rest of this looks ok, I can finish that up. - I hope the location of IsValidSocketAddr is correct. Lmk if it isn't. **Release note**: ```release-note Adding validation to kube-scheduler at the API level ```
-
- 03 Sep, 2018 8 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Affinity/Anti-Affinity Optimization of Pod Being Scheduled **What this PR does / why we need it**: Following #66948, it was noticed that the applied optimizations for anti-affinity rules lookup of existing pods could be further applied to checking affinity and anti-affinity terms of the Pod being scheduled. This is done by mapping topology pairs to pods that potentially match the pod being scheduled instead of mapping nodes to matching pods, and accordingly the search space is reduced. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #67738 **Special notes for your reviewer**: /sig scheduling /sig scalability **Release note**: ```release-note Improve performance of Pod affinity/anti-affinity in the scheduler ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67397, 68019). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Fix conversion for autoscaling/v1 ObjectMetricSource and add fuzzer **What this PR does / why we need it**: Selectors in ObjectMetricSource's weren't being persisted through roundtrip conversions, and this wasn't caught because we had no fuzzer testing MetricIdentifier selectors **Which issue(s) this PR fixes**: none **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67397, 68019). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. kubeadm: fix offline and air-gapped support **What this PR does / why we need it**: 1. Change the error output of getAllDefaultRoutes() so that it includes information on which files were probed for the IP routing tables even if such files are obvious. Introduce a new error type which can be used to figure out of this error is exactly of the "no routes" type. 2. If netutil.ChooseBindAddress() fails looking up IP route tables it will fail with an error in which case the kubeadm config code will hard stop. This scenario is possible if the Linux user intentionally disables the WiFi from the distribution settings. In such a case the distro could empty files such files as /proc/net/route and ChooseBindAddress() will return an error. For improved offline support, don't error on such scenarios but instead show a warning. This is done by using the NoRoutesError type. Also default the address to 0.0.0.0. While doing that, prevent some commands like `init`, `join` and also phases like `controlplane` and `certs` from using such an invalid address. 3. If there is no internet, label versions fail and this breaks air-gapped setups unless the users pass an explicit version. To work around that: - Remain using 'release/stable-x.xx' as the default version. - On timeout or any error different from status 404 return error - On status 404 fallback to using the version of the client via kubeadmVersion() Add unit tests for kubeadmVersion(). **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: refs kubernetes/kubeadm#1041 **Special notes for your reviewer**: 1st and second commits fix offline support. 3rd commit fixes air-gabbed support (as discussed in the linked issue) the api-machinery change is only fmt.Errorf() related. **Release note**: ```release-note kubeadm: fix air-gapped support and also allow some kubeadm commands to work without an available networking interface ``` /cc @kubernetes/sig-cluster-lifecycle-pr-reviews /cc @kubernetes/sig-api-machinery-pr-reviews /assign @kad /assign @xiangpengzhao /area UX /area kubeadm /kind bug
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Increase Horizontal Pod Autoscaler update frequency to every 15s **What this PR does / why we need it**: PR increases Horizontal Pod Autoscaler default update interval (30s -> 15s). It will improve HPA reaction time for metric changes. **Release note**: ```release-note Increase Horizontal Pod Autoscaler default update interval (30s -> 15s). It will improve HPA reaction time for metric changes. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 68127, 68143). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. GC kubemark image after cluster starts up Last piece to fix https://github.com/kubernetes/kubernetes/issues/59567 /cc @wojtek-t ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 68127, 68143). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Increase metrics-server scrape frequency to 30s With new release of metrics-server and it's performance improvement, we will reduce metrics pipeline latency from 60s to 30s. This is part of sig-autoscaling effort to improve HPA https://github.com/kubernetes/kubernetes/pull/68021 ```release-note Increase scrape frequency of metrics-server to 30s ``` /cc @kawych @mwielgus @DirectXMan12 @dashpole
-
Marek Siarkowicz authored
-
Eunsoo Park authored
This change enables ```getLoadBalancer``` to return the loadbalancer even if no floating ip is associated to the VIP port of the loadbalancer. Signed-off-by:
Eunsoo Park <esevan.park@gmail.com>
-
- 02 Sep, 2018 22 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Add --server-dry-run flag to `kubectl apply` - Adds the flag - changes the helper so that we can pass options for patch, - Adds a test to make sure it doesn't change the object **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note Add new `--server-dry-run` flag to `kubectl apply` so that the request will be sent to the server with the dry-run flag (alpha), which means that changes won't be persisted. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65566, 67959, 68029, 68017, 67263). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Move kubelet ComponentConfig external types to `k8s.io/kubelet` **What this PR does / why we need it**: This PR implements most of kubernetes/community#2354 for the kubelet. The PR: - Moves `k8s.io/kubernetes/pkg/apis/kubeletconfig` as-is to `k8s.io/kubernetes/pkg/apis/config` as agreed - Moves the external types to the new staging repo `k8s.io/kubelet`, in the `k8s.io/kubelet/config/v1beta1` package. - Makes `k8s.io/kubernetes/pkg/apis/config/v1beta1` source the types from `k8s.io/kubelet/config/v1beta1`. The defaulting and conversion code is kept in this package as before. - All references to these packages have been updated. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: ref: kubernetes/community#2354 **Special notes for your reviewer**: This PR depends on getting https://github.com/kubernetes/kubernetes/pull/67780 merged first. **Release note**: ```release-note kubelet v1beta1 external ComponentConfig types are now available in the `k8s.io/kubelet` repo ``` /assign @sttts @mtaufen @liggitt
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65566, 67959, 68029, 68017, 67263). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. add test to verify vsphere cloud provider report node hostname **What this PR does / why we need it**: as in pull #67922 has modify vsphere cloud provider to report node hostname, this patch is to add the test for it. also fix an issue at InstanceID(), it suppose to return cloudprovider.InstanceNotFound when vm not found, but it did double error type translation with a retry() logic, after removing the retry() (which is not necessary), the logic is simpler, and easier to understand how double translation happened, after the fix, test TestInstance() can pass **Which issue(s) this PR fixes** : Fixes #67714 **Special notes for your reviewer**: as in the process of create pull to fix https://github.com/crosscloudci/crosscloudci/issues/65#, i saw #67922 already merged, so this pull is just to submit the test part. **Release note**: ```release-note none ``` /cc @abrarshivani @BaluDontu @divyenpatel @imkin @kerneltime @luomiao @frapposelli @dougm @liggitt /sig cloudprovider
-
Antoine Pelisse authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. cluster/addons: add labels to fluentd owner files **What this PR does / why we need it**: this PR adds SIG labels to fluentd OWNER files: - cluster/addons/fluentd-elasticsearch/OWNERS - cluster/addons/fluentd-gcp/OWNERS **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: let me know if the labels need adjustment. **Release note**: ```release-note NONE ``` /assign @roberthbailey @mikedanese /cc @timothysc /sig gcp /sig instrumentation /kind cleanup
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Add gnufied as approver for attach/detach controller Hopefully has reviewed and made enough fixes in this area to understand the code thoroughly. ```release-note None ``` /assign @saad-ali @jsafrane
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Fix some descriptions for kubeadm
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. as hostpathtype owner, adds myself to OWNERS file **What this PR does / why we need it**: As the owner of HostPathType, I would like to add myself to OWNERS file. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: /cc thockin saad-ali **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Add Godeps OWNERS for csi-api **What this PR does / why we need it**: Add Godeps OWNERS for csi-api. I just ran `hack/update-staging-godeps.sh` to do this. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Refactor the kube-controller-manager ComponentConfig structs **What this PR does / why we need it**: This PR cleans up the kube-controller-manager structs in the componentconfig package and fixes various structural issues in the current code, in order to make it possible to later move the code out to external API groups (as a starting point `GenericControllerManagerConfiguration` to `k8s.io/controller-manager`). **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: ref: https://github.com/kubernetes/community/pull/2354 This PR depends on: - [x] https://github.com/kubernetes/kubernetes/pull/67149 - [x] https://github.com/kubernetes/kubernetes/pull/67090 - [x] https://github.com/kubernetes/kubernetes/pull/67159 - [x] https://github.com/kubernetes/kubernetes/pull/67207 - [x] https://github.com/kubernetes/kubernetes/pull/66722 **Special notes for your reviewer**: Please only review the following commits: - **Refactor the k-c-m ComponentConfig structs to they can be moved out** - **Fixup cmd/kube-controller-manager code after struct changes.** **Release note**: ```release-note NONE ``` /assign @sttts @stewart-yu @liggitt @thockin
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67864, 68158). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Update echoserver version used to 2.2 Change-Id: Ic1dcb2c64ac682ca601ab2589fd6af70d4e09620 **What this PR does / why we need it**: In https://github.com/kubernetes/kubernetes/pull/67578 we updated the image. Let's please switch to the new image **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Taint node in paralle. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #67823 **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. client: periodically reload InClusterConfig token /sig auth /sig api-machinery ```release-note NONE ```
-
Christoph Blecker authored
-
Mike Danese authored
-
- 01 Sep, 2018 2 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63437, 68081). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Enable ImageLocalityPriority by default with integration tests **What this PR does / why we need it**: This PR is a follow-up to [#63842](https://github.com/kubernetes/kubernetes/issues/63842). It moves the ImageLocalityPriority function to default priority functions of the default algorithm provider and adds integration tests for the updated scheduling policy. - Compared to [#64662](https://github.com/kubernetes/kubernetes/pull/64662), this PR does note provide e2e test due to concerns about a large image may add too much overhead to the testing infrastructure and pipeline. We should add e2e tests in the future with the use of large enough image(s) in following PRs. - Compared to [#64662](https://github.com/kubernetes/kubernetes/pull/64662), this PR simplifies the code changes and keeps code changes under test/integration/scheduler/. - The PR contains a bug fix for [#65745](https://github.com/kubernetes/kubernetes/pull/65745) - caught by the integration test - where the image states are not properly cloned to the scheduler's cachedNodeInfoMap. We might split this fix into a separate PR. The integration test covers what follows: a pod requiring a large image (~= 3GB) is submitted to the cluster and there is a single node in the cluster has the same large image; the pod should get scheduled to that node. We might also consider whether more scenarios are desired. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: Kindly ping @resouer and @bsalamat **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63437, 68081). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. fix #51135 make CFS quota period configurable **What this PR does / why we need it**: This PR makes it possible for users to change CFS quota period from the default 100ms to some other value between 1µs and 1s. #51135 shows that multiple production users have serious issues running reasonable workloads in kubernetes. The latency added by the 100ms CFS quota period is adding way too much time. **Which issue(s) this PR fixes**: Fixes #51135 **Special notes for your reviewer**: - 5ms is used by user experience https://github.com/kubernetes/kubernetes/issues/51135#issuecomment-384908627 - Latency added caused by CFS 100ms is shown at https://github.com/kubernetes/kubernetes/issues/51135#issuecomment-373454012 - explanation why we should not disable limits https://github.com/kubernetes/kubernetes/issues/51135#issuecomment-385346661 - agreement found at kubecon EU 2018: https://github.com/kubernetes/kubernetes/issues/51135#issuecomment-386623964 **Release note**: ```release-note Adds a kubelet parameter and config option to change CFS quota period from the default 100ms to some other value between 1µs and 1s. This was done to improve response latencies for workloads running in clusters with guaranteed and burstable QoS classes. ```
-