GitLab

* Move lintand test jobs to Github Actions

* Integrate the gofmt check into Makefile

* Extract version for gobgp, gorelease, gomoq

This function is useful for more than just the NRC, move it up a layer
into the global utils so it can be used from multiple controllers.

https://github.com/cloudnativelabs/kube-router/issues/630

Also separates logic so that it can be tested more easily, and adds unit
tests to make sure there is no regression.

Fixes #1083

Previously, this section was commented out and full testing to ensure
that the policies matched was not performed. Now the unit tests are more
complete and actually test that the expected policies are present.

Use startBgpServer() rather than doing things individually, so that we
can follow the logic path of how kube-router actually works better. This
allows us to use annotations rather than set stuff manually and allows
us to test more of the code-path of the NRC.

Additionally, this change allows us to actually test some errors better
such as, make sure that startBgpServer() actually throws the error we
expect when only one part of the prepend ASN annotation is present.
Previously, we were not actually testing this code path.

gobgp 2.27.0
k8s 1.21

Signed-off-by: Mikhail Sakhnov <mikhail@skhnv.me>

* fix(nsc): Overly eager IPVS updating

Switches the endpoint map comparison in OnEndpointsUpdate from being a
DeepEqual, to instead checking that all services exist, and that their
associated endpoints are similar.

Ordering is no longer considered important in regards to the IPVS
update check.

Fixes #1026 

Includes an upgrade to gobgp 2.26.0

* ipset restore: use temporary sets and swap them into the real ones

* move const

* switch to shared tmp ipsets

* preemptively flush tmp set in case it already existed

See the following for more details:
https://github.com/cloudnativelabs/kube-router/security/code-scanning?query=ref%3Arefs%2Fpull%2F1065%2Fmerge+tool%3ACodeQL

See:
https://github.com/cloudnativelabs/kube-router/security/code-scanning/1?query=ref%3Arefs%2Fpull%2F1065%2Fmerge

It is standard practice in Go to not capitalize error messages:
https://github.com/golang/go/wiki/CodeReviewComments#error-strings

See also: https://docs.github.com/en/code-security/secure-coding/configuring-code-scanning

Configuration taken from: https://github.com/github/codeql-action/blob/main/README.md#usage