* dont start nfs always when bindip is set

* be smarter about logging when service is stopped

* all() to any()

* recreate user homedir on do_update (if needed)

(cherry picked from commit cfa15e6897de7238412feab05af9e3a80d79429b)

* flake8

(cherry picked from commit 0c9b83480dd7f841d11cd36a86c7d24a2e526988)

* address review

(cherry picked from commit 9d503287cf94c42d7c53b213a666cac45fbc96c6)
Co-authored-by: caleb <yocalebo@gmail.com>

Besides being UNAVAIL, they can also be FAULTED, etc.

Incorrect permissions on this directory will prevent winbindd
from starting.

(cherry picked from commit a04410c23b6484884d7a6b61dbf4191cc3a2c1fb)
Co-authored-by: Andrew Walker <awalker@ixsystems.com>

Co-authored-by: caleb <yocalebo@gmail.com>

(cherry picked from commit f08e50771f8e769087ee5692c6226713ef0162e2)
Co-authored-by: themylogin <themylogin@gmail.com>

* remove geom.scan and optimize device.get_disk(s)

* flake8 fix

Co-authored-by: caleb <yocalebo@gmail.com>

Co-authored-by: caleb <yocalebo@gmail.com>

(cherry picked from commit 585b10d939ef0fab858496cbc48bbc3de2ab5bca)
Co-authored-by: themylogin <themylogin@gmail.com>

NAS-112357 / 12.0 / Do not include disks that do not spport S.M.A.R.T. in smart.test.disk_choices (#7625)

(cherry picked from commit c147e900b57cd875ded08f55acfe3e5c89f1f5fd)
Co-authored-by: themylogin <themylogin@gmail.com>

* make DiskStats not suck

* address review and remove osc code

* calculate difference of data every 2 seconds

(cherry picked from commit be094e07edd2cd2df4fe59d3ec24d6c85b12b020)
Co-authored-by: themylogin <themylogin@gmail.com>

* correctly retrieve parent dataset in pool.py

* prevent creation of ds/zvol if parent is readonly

* Fix groupmap synchronization

Due to API changes, we now need full idmap config in passive
controller smb4.conf file. We also need to ensure that
RID counter for passdb and groupmap operations is same.

* Create winbindd_idmap.tdb if it doesn't exist

(cherry picked from commit 122f048d72058ed7572512a48c9b5830dcb3a0fb)
Co-authored-by: Andrew Walker <awalker@ixsystems.com>

Flush out samba's gencache before starting test, also
chown datasets so that they're owned by our SMB user.

those are not for HA only CORE

* Added propper timeout with exit 1 in boot.exp and install.exp

changed the install timout to 20 min instead of 30 minutes
changed the boot timout to 12 min instaed of 30 min

* fixed the boot timeout time

If group_mapping.tdb contains a duplicate gid entries,
then append second entry to `invalid` list to be deleted
during batch OPs. Also ensure that we always have entry
for S-1-5-32-545.

Samba server will check ZFS_PROP_WRITTEN on snapshots to determine
whether to present them the VSS clients.

At present this is limited to verifying that shadow copies are
presented over SMB1 / SMB2 and that handles can be opened on
data and streams.

Future improvement will be validation of contents of previous
versions of files and streams, but this will require some
enhancement of py-libsmb.
Co-authored-by: Andrew Walker <awalker@ixsystems.com>

* add nfsd.scope and nfsd.owner_major on Core HA

* add comment about setting 2 sysctls to same value

* Make netbiosname tests ha-aware

* Rewrite SMB SID on virtual hostname change

* Fix ups reporting when running in slave mode

This commit fixes an issue when we would not be showing reporting for UPS when it was running in slave mode because collectd stores ups logs in a different directory when it's running in slave mode.

* Make _base_path a property