NAS-126782 / 13.1 / PoolScrubService.__run: reduce memory usage during zpool history (by rkojedzinszky) (#12903)

We have deprecated this feature in Samba versions more recent than
4.15.

This parameter is deprecated and no longer exists in Samba 4.19.

Remove `test_exclude_recycle_bin` as it is not possible to run this test anymore without local S3 service (#12696)

Co-authored-by: Caleb <yocalebo@gmail.com>

The problem: The NFS bindip cannot be configured if the selected IP address is not functional. This setting is in /etc/rc.conf.freebsd. NFS is started and configured before the network is started. NFS has a post network start event handler that will restrart NFS if bindip is configured in the DB.

However, the NFS bindip setting was blocked at boot during the initial configuration run because the network subsystem had not yet completed startup. This resulted in no NFS bindip configuration.

The fix: In the post network start handler, regenerate rc.conf.freebsd before restarting NFS.

Co-authored-by: Caleb <yocalebo@gmail.com>

(cherry picked from commit 7a5ee4c7b3b57b861120c8117b7feb234560678b)

Decrease alert priority of zpool upgrade to NOTICE (#12299)                                                                                                                                                                                                                         Placing this as a warning encourages users to upgrade pool when                                                                           it's not really necessary and should be evaluated carefully by                                                                            the administrator. (#12300)
Co-authored-by: Andrew Walker <awalker@ixsystems.com>

Backend is required. This is set in SCALE, but change wasn't
backported to Core / Enterprise.

(cherry picked from commit e7399f10e1d042b27465d2e600e6ae0cd3f3ab66)
Co-authored-by: Caleb <yocalebo@gmail.com>

(cherry picked from commit 035e2d381c68053e5c0865147855d7f9c2fa713e)
Co-authored-by: themylogin <themylogin@gmail.com>

Co-authored-by: Caleb <yocalebo@gmail.com>

(cherry picked from commit 8b0e3e07b45ccc0f6f4a0ab41fe42110dc2122f5)
Co-authored-by: Caleb <yocalebo@gmail.com>

(cherry picked from commit 634eefec1890989c8e4411e5ff3c6f9ccd334d6f)
Co-authored-by: themylogin <themylogin@gmail.com>

* Mark minio service as deprecated

(cherry picked from commit da5659507fad4ea66be4c6b975fd6d704d0d30a0)

* Update src/middlewared/middlewared/plugins/update_/install_freebsd.py
Co-authored-by: Caleb St. John <30729806+yocalebo@users.noreply.github.com>
(cherry picked from commit 69fa464bb2a07156d96ce076a101a45a061a6d62)

* Forbid starting minio

---------
Co-authored-by: themylogin <themylogin@gmail.com>

(cherry picked from commit c752543cd8af65010c66914881119738feede295)
Co-authored-by: Andrew Walker <awalker@ixsystems.com>

There is no technical reason to prevent using question mark in
an SMB password.

NAS-119369 / 13.1 / Properly account for the case when TC container might not be running (by sonicaj) (#11948)

This commit adds changes to try and disable 2fa instead of querying system info as a customer had faced this scenario in previous versions and we want to be sure we are not allowing that to happen.

(cherry picked from commit 0d8b00348e31ab37e0caf64a43fdf23802aa5e86)
Co-authored-by: Waqar Ahmed <waqarahmedjoyia@live.com>

* NAS-117931 / 22.12 / HTTP Basic Auth is unavailable when OTP is enabled (#9742)

* HTTP Basic Auth is unavailable when OTP is enabled

* OTP integration tests

* Remove second auth otp test

---------
Co-authored-by: themylogin <themylogin@gmail.com>

NAS-123419 / 13.1 / Add overwrites for TrueCommand service start and get_state (by ZackaryWelch) (#11858)

* Added TrueCommand debugs. Ensured service will only be started, not restarted, and won't start if already enabled

(cherry picked from commit 6b20b1eb6ea5d30a0acb37143756a3b570e0c40a)

* Removed misleading log statements

(cherry picked from commit 78465f0fc67a72654d57e0a1f2f0b936c5a87db1)

* Reverted a couple of changes found not to matter in testing

(cherry picked from commit 728ca3ebf427080efa5fee7a8e543f48e34143e9)

---------
Co-authored-by: Zack Welch <zwelch@ixsystems.com>

(cherry picked from commit e4ce3c29)

This has knock-on effects regarding failover when AD is broken.
We should ensure that it's always possible to get system dataset
set up, and in principle if AD join is already broken things
can't really get worse by moving around the system dataset.

(cherry picked from commit 980a4de5a6d36663dd30b4f8504bb44d13f7c16a)
Co-authored-by: Andrew Walker <awalker@ixsystems.com>

NAS-122482 / 13.1 / Add SNMP tests that verify the response uses the same IP as request (by bmeagherix) (#11577)

* NAS-122482 / 13.1 / Add SNMP tests that verify the response uses the same IP as request

* Add pysnmplib to requirements.txt

* Add SNMP tests that verifly the response uses the same IP as request

(cherry picked from commit c33586ec

)

* Restore depends

---------
Co-authored-by: bmeagherix <118192357+bmeagherix@users.noreply.github.com>
Co-authored-by: Brian Meagher <brian.meagher@ixsystems.com>

(cherry picked from commit 5d6d26fa41209e79316a78804332e7006586dcd8)
Co-authored-by: themylogin <themylogin@gmail.com>

(cherry picked from commit 2d626bcd023d0df512fada96c0784cbf38f8d026)
Co-authored-by: Andrew Walker <awalker@ixsystems.com>

* etc_files/local/proftpd.conf:
    Remove MultilineRFC2228 and no_cert_request settings from the proftpd.conf mako file.
* plugins/ftp.py:
    Add validation check to block user setting no_cert_request.
* tests/api2/test_200_ftp.py:
    Add simple checks to confirm MultilineRFC2228 not preset and we block setting no_cert_request

No DB or API changes were made.

NAS-122299 / 13.0 / Add testing recyclebin