* Add audit for iSCSI endpoints

* Add iSCSI audit tests

* fix FIPS on HA

(cherry picked from commit 99ef6a030d957ff3f7bf20cc10683c44d95ae9bd)

* failover_/boot.py -> failover_/reboot.py

(cherry picked from commit eb34fe8ee9286e42c335c7dc53c046a81597daf5)

* remove fips test

(cherry picked from commit b86bb14019a5ad890bfb7bb8a62fb97f17750d8d)

---------
Co-authored-by: Caleb <yocalebo@gmail.com>

* Make sure netdata state persists across upgrades

* Handle edge case for ix_state dir not existing for some reason

NAS-128140 / 24.10 / Account for failover status when reporting backup node as ready (by sonicaj) (#13467)

NAS-124648 / 24.10 / Add a new endpoint to reboot standby controller (by sonicaj) (by bugclerk) (#13461)

* Add basic failover service to reboot standby controller

(cherry picked from commit 872816069a8bd4d4870c56dda846a0d3c7442e66)
(cherry picked from commit 54ac094bd2113c1435bc88ef551db5ba1bc3dd1a)

* Make sure we wait for standby node to come back up as and report back as ready

(cherry picked from commit ba74383b124c3f0b121c7d3b0b59c837216ab652)
(cherry picked from commit 819097febe1ac2f55293ecf94a6b57d3e9971222)

* Add boot id check to ensure the standby node did actually reboot

(cherry picked from commit 23a5e9eaf0670b4a16785b9ce9e780e192cec384)
(cherry picked from commit 2de0382cf2d256b139a2242437b1a5df8aa1346d)

* Update job progress while rebooting standby

(cherry picked from commit 9984285bc2d7f7370a8c42317bdc542b182abc62)
(cherry picked from commit 567322dc533b0fcee7de8e746a82c86cb1b08026)

* Do not allow changing FIPS settings if HA is not healthy

(cherry picked from commit 01b198dc4717a37e7273ef14d840ff9c4a5c507a)
(cherry picked from commit abf234ff3ab3d9b6570d646c7ed190883b9b7deb)

* Add a method to retrieve boot ids

(cherry picked from commit 399fc6ea2edec8783947102410bef8a9f7a75647)
(cherry picked from commit 3d3ad0b067c09682f708956925f64a75bcdcac1c)

* Persistently save boot ids of nodes

(cherry picked from commit 879ee6d641a167550503a944086d9e5e1fb17712)
(cherry picked from commit fd94242065b2ee8f95163be12ca01ea51275ff4d)

* Add a method which determines if reboot is required for HA

(cherry picked from commit de4657a740be4e5a34668902d4fe541405393d6e)
(cherry picked from commit 525d8d07e41839518b3fb1e15beb9cbcabe0915c)

* If no reboot is required, remove fips_toggled key

(cherry picked from commit e5913072462bfea440c4b1bd01e9fccadeac33fa)
(cherry picked from commit c3dbb25b8f19bf69418c761575a9c57cb4a7765e)

* Don't raise a connect error if not able to communicate with remote

(cherry picked from commit 19b7b59fb3f55a960c7177ce1e3be8c25271271c)
(cherry picked from commit 0a4407319d6037a5ad506067ab73c2c0388789a9)

* Make sure we update our reboot cache keys when node becomes master:

(cherry picked from commit eda3938b92cb2bc1145947a2b092f8d35deb861e)
(cherry picked from commit 6a1d5d146cb0394e67f674d0b95a91268aa8222b)

* Fix typo

(cherry picked from commit b21ee544421f3b113f3f6aabde52a702aad63e7d)

* Add copyright header to reboot file

(cherry picked from commit a8b3c1f8a71e44181e625008dd737b047326998b)

* Add logging statement to clarify when we are updating reboot cache

(cherry picked from commit cb1a5ae682a16d47ac50318d2b3f7264aebdc2a2)

* Use become_passive to reboot standby node

(cherry picked from commit 4f9d1eda83696252bf6b7fb30777acda97aad825)

* Move reboot required for failover to failover disabled reasons

(cherry picked from commit 7c2c60af438a35c20e2f0ff3e1818221865adf71)

* Do not add fips reboot reason to disabled reasons output endpoint

(cherry picked from commit d78316a6e6a2637107b3537d74868a2ecbe962a0)

* Refactor the new service part to failover.reboot

(cherry picked from commit 0eedc915e441df660742b40f8c265a5c6ecc1505)

* Add a boolean endpoint which dictates if reboot is required for HA

(cherry picked from commit f63052a5ebce4b5731765143f675c9cce4bb22f5)

* Move reboot standby endpoint to failover.reboot service

(cherry picked from commit d32d14136c1ba40b4297deb6b495cfeb68ea267b)

* Make sure standby_reboot can only be called on master node

(cherry picked from commit 50af77eaff34c2c02040657d362a7d51673a18a2)

* Remove reason from failover.reboot.info endpoint

(cherry picked from commit 78246b8b272ccd9069e6eca86baff7f1bb4b24c3)

* Add individual reasons to disabled reasons for retrieving failover being required on ha nodes

(cherry picked from commit e7365098d703fbacf79196f4bce06eaeb716bb59)

* Fix disabled reasons endpoint logic for reboots

(cherry picked from commit 5fabe5828742236092bb09c672e8f404074209fd)

* Allow changing fips settings if the only reasons are rebooting because of fips

(cherry picked from commit 50505dc3f839ea855f30a6ce625429cd694020e7)

* Add cli namespace for failover.reboot service

(cherry picked from commit 3692117f62d627a0c468f49bebf22861928eadae)

* Simplify faiover.disabled.reasons endpoint wrt reboot logic

(cherry picked from commit cc0fcb0c50c87cbd40d1b95a534488428c500da8)

* Fix edge case

(cherry picked from commit 485deb0f6a91ae18e3f520485d6635d14a69017b)

---------
Co-authored-by: Waqar Ahmed <waqarahmedjoyia@live.com>

* Make REST and websocket calls VIP aware

(cherry picked from commit 7e5f70beda3f829046d2798569f8ff01c0bc0156)

* Fix syntax for old python

(cherry picked from commit 2937ffde6a26e7b905e79b6910b41cea84365aa1)

* Fix SSH for VIP

(cherry picked from commit 977344916b0dbf1d195bf73febcc5bba1999edcc)

* use server variable instead of calling host()

* flake8 while im here

* remove USE_VIP env var

* address review

---------
Co-authored-by: Andrew Walker <awalker@ixsystems.com>

This commit fixes an issue where system boot id is currently changing on each middleware restart, we now introduce changes to make sure that it remains persistent across a single boot of the system itself and not just middleware.

* Fix cron fields values, follow-up to NAS-125384

(cherry picked from commit 48462491f87196a44b70c9581fb6169b8a57710d)

* Merge migrations

You should reset it

* add new changes for new jenkins to runtest.py

* fix conftest.py to use proper IP address on HA

* simplify test_001_ssh.py

* fix and simplify test_002

* fix and simplify test_003

* fix and simplify test_005

* fix and simplify test_006

* fix and improve API WS client

* address review

* be less strict on finding default gateway

* Add globally unique system ID

* Update migration

There are various parameters in which the administrator can provide
arbitrary commands and scripts to run via auxiliary parameters, some of
which may be executed as the root user. This can present a risk of
a limited administrator accidentally or intentionally performing actions
on the NAS with privileges that are higher than intended.

* Cloud backup API

* Validate cloud backup restore destination path

standby node.
Added stop of mountd during standby mode processing.

Since the initial angelfish release in order to facilitate SMB
clustering we have stored Samba's global section (services->SMB) in the
samba registry via libsmbconf. Libsmbconf is more strict at validation
of what gets written in the configuration. Some core users have copius
smb_options with many comments in them. This shifts the function
that was used for stripping comments from auxiliary parameters from
sharing.smb to a utility function for consumption by both sharing.smb
and services.smb.

* Forbid access to cloud sync task scripts to non-FULL_ADMIN users

* Address review

* Fix cloud sync pre-/post-scripts

* Use `tempfile.NamedTemporaryFile`

We no longer have unified ACL codebase with FreeBSD and so we
no longer need to have separate acl_base and acl_linux files.

Refactoring work related to choices for SMB share ACL users
and groups revealed a long-standing bug whereby `smb` key
was omitted from objects from directory services.

Add explicit tests for the xattr handlers for alternate data
streams and the test assets by which to accomplish this.