Skip to content

GitLab

Switch branch/tag
  1. 22 Sep, 2023 4 commits
  3. 18 Sep, 2023 2 commits
  5. 01 Sep, 2023 1 commit
  7. 29 Aug, 2023 1 commit
  9. 27 Aug, 2023 1 commit
  11. 16 Aug, 2023 3 commits
  13. 07 Aug, 2023 1 commit
  15. 01 Jul, 2023 1 commit
  17. 28 Jun, 2023 1 commit
    • bugclerk's avatar
      Allow sysdataset move if AD faulted (#11600) · bdcc2e0b
      bugclerk authored 
      
This has knock-on effects regarding failover when AD is broken.
We should ensure that it's always possible to get system dataset
set up, and in principle if AD join is already broken things
can't really get worse by moving around the system dataset.

(cherry picked from commit 980a4de5a6d36663dd30b4f8504bb44d13f7c16a)
Co-authored-by: default avatarAndrew Walker <awalker@ixsystems.com>
      bdcc2e0b
  19. 27 Jun, 2023 3 commits
  21. 23 Jun, 2023 1 commit
  23. 21 Jun, 2023 1 commit
    • mgrimesix's avatar
      NAS-122463 / 13.1 / Remove deprecated proftpd settings (#11562) · 2aeb3a8b
      mgrimesix authored 
      * etc_files/local/proftpd.conf:
    Remove MultilineRFC2228 and no_cert_request settings from the proftpd.conf mako file.
* plugins/ftp.py:
    Add validation check to block user setting no_cert_request.
* tests/api2/test_200_ftp.py:
    Add simple checks to confirm MultilineRFC2228 not preset and we block setting no_cert_request

No DB or API changes were made.
      2aeb3a8b
  25. 14 Jun, 2023 1 commit
  27. 02 Jun, 2023 3 commits
  29. 01 Jun, 2023 2 commits
    • Andrew's avatar
      Fix and enhance recycle test (#9939) · d0ed2385
      Andrew authored 
      Add tests to validate:
1. files purged when deleted from recycle paths
2. per-dataset recycle bins are automatically created

This also fixes typo in path for original refactor of
recycle test.
      d0ed2385
    • Andrew's avatar
      Improve test_420_smb - use python SMB client (#9933) · b549496a
      Andrew authored 
      Our existing tests failed to catch situation where recycling
process would cause an SMB service disconnection. The new
tests explicitly cover basic ops (creating / deleting files,
creating, removing directories) and also ops on the
recycle bin over the SMB1 and SMB3 protocols. This improves
test coverage while also ensuring that tests are performed
under a single SMB session.
      b549496a
  31. 31 May, 2023 2 commits
  33. 26 May, 2023 1 commit
  35. 18 May, 2023 1 commit
  37. 17 May, 2023 2 commits
    • Andrew Walker's avatar
      Improve IPMI password validation (#11325) · 7cad14b8
      Andrew Walker authored 
      This addresses a couple of issues with IPMI password validation

1) The webui lists password complexity requirements that are
   not validated within middleware before sending payload
   through ipmitool.

2) Password length of 20 characters is enforced in middleware,
   but this value exceeds that supported by ipmi 1.5 (16 characters).

The first item is problematic because the error messages from ipmitool
for passwords that lack sufficient complexity are less than helpful
("Request data field length limit exceeded").

The second item is also incredibly problematic because on some
devices a password of more than 16 characters will be silently
truncated to 16 characters.

This PR shifts validation to the middleware schema by introducing
two changes:

a) Password() schema type. This currently only hardcodes 'private'
key, but the guiding principal is that we can start shifting
places where we are handling passwords to have a common schema
so that it is simpler to identify and audit where middleware is
handling passwords.

b) PasswordComplexity validator. This implements validation of
the sort where you need two or three of certain character types
in a password.
      7cad14b8
    • Eric Turgeon's avatar
      Fixed internal release build train test and added longer timeout for iscsi wait (#11323) · b26433a2
      Eric Turgeon authored
      b26433a2
  39. 15 May, 2023 1 commit
  41. 12 May, 2023 2 commits
  43. 11 May, 2023 3 commits
  45. 09 May, 2023 2 commits