1. 20 Oct, 2023 2 commits
  2. 19 Oct, 2023 12 commits
    • bmeagherix's avatar
      NAS-121831 / 24.04 / Add script explaining that package management tools are disabled (#12140) · c3d46fef
      bmeagherix authored
      Add script explaining that package management tools are disabled
      
      Since our build process needs to perform some apt install commands,
      delay setting this script executable until afterwards.
      c3d46fef
    • Waqar Ahmed's avatar
    • Waqar Ahmed's avatar
      Fix flake8 · 15c4adbc
      Waqar Ahmed authored
      15c4adbc
    • Waqar Ahmed's avatar
    • Waqar Ahmed's avatar
      5b655684
    • Waqar Ahmed's avatar
      83332a76
    • Waqar Ahmed's avatar
      Fix encryption keys not syncing to backup node on middleware restart · 9aa7c153
      Waqar Ahmed authored
      This commit fixes an issue where when backup node middleware restarts, we do not sync keys from master node because when we tried to sync the keys on middleware boot - we were not able to talk to active node which is highly likely because middleware has not initialised itself properly at that point, so we add a delay to ensure we only do that once middleware has booted and initialised itself properly.
      9aa7c153
    • bugclerk's avatar
      Fix rendering docs (#12357) · 2d7adc8b
      bugclerk authored
      
      (cherry picked from commit 111474c56a16e6c6f22f17c5c265cb3ad445cb5a)
      Co-authored-by: default avatarthemylogin <themylogin@gmail.com>
      2d7adc8b
    • bugclerk's avatar
      Fix OVH DNS Authenticator (#12358) · 08992c43
      bugclerk authored
      
      (cherry picked from commit c4c1246b22bb34427469328b48c46948c672451b)
      Co-authored-by: default avatarthemylogin <themylogin@gmail.com>
      08992c43
    • Waqar Ahmed's avatar
      NAS-124598 / 24.04 / Optimize retrieving shares/tasks information (#12316) · fa6fd37e
      Waqar Ahmed authored
      * Do not retrieve datasets associated with shares
      
      * Remove sharing_task_datasets method as it's not being used anywhere now
      
      * Add a method to cache locked datasets
      
      * Use cached locked datasets in sharing task service and have an extra param to toggle that
      
      * Invalidate locked datasets cache whenever any dataset is unlocked
      
      * Rename extra parameter name to use_cached_locked_datasets
      
      * Only cache zfs datasets if the system is ready
      
      * Cover sharing.smb.query usages to selectively not use cache
      
      * Make retrieving locked info attr optional by an extra parameter
      
      * Cover sharing.smb.query usages to not retrieve locked share info where not required
      
      * Cover sharing.nfs.query usages to not retrieve locked share info where not required and also bypassing cache where required
      
      * Cover iscsi.extent.query usages to not retrieve locked share info where not required and also bypassing cache where required
      
      * Cover cloudsync.query usages to not retrieve locked tasks info where not required and also bypassing cache where required
      
      * Add locked datasets cached to pool.dataset namespace to avoid hitting process pool
      
      * Remove usages of zfs.dataset.locked_datasets_cached
      
      * Remove zfs.dataset.locked_datasets_cached method as it's not being used anymore
      
      * If select is specified and lock field is not required - we should not bother to get it
      
      * Use select where we can instead of retrieve_locked_info extra param
      
      * Invalidate locked datasets cache whenever any dataset is locked
      
      * Add integration test to validate sharing services lock key
      
      * Add an integration test to verify if locked field is not specified we don't retrieve it
      
      * Clean integration test
      
      * Add integration test to verify cached extra parameter functioning as expected
      
      * Fix iscsi extent volume creation parameters
      fa6fd37e
    • mgrimesix's avatar
      79e2989d
    • Waqar Ahmed's avatar
      Only unlock datasets which are requested on failover · fb20c2f3
      Waqar Ahmed authored
      This commit fixes an issue where we tried to unlock all the passphrase encrypted datasets on failover each time we imported a pool but that was bound to fail as pools which had not imported at that time would not be found and would obviously result in erroneous logging. So changes have been made to only unlock datasets of pool which has been imported at the time.
      fb20c2f3
  3. 18 Oct, 2023 2 commits
    • bugclerk's avatar
      NAS-124687 / 24.04 / Remove ad_bindpw column from Activedirectory · 445ea28e
      bugclerk authored
      
      Historically, there was a configuration scenario with GELI encrypted data pools and system dataset location that would require storing the AD bind password in our configuration database. With SCALE, this configuration SMB_HA_LEGACY was formally deprecated and removed.
      
      In early Cobia development we began to no longer keep the AD bind password in the configuration database for even transient purposes during domain join, but migration to actually drop the database column was actually omitted at that time. This commit finishes the process of removal. There are no cases where this data is used (even if somehow present in upgraded server's configuration file) and so there are no edge cases where this migration will break users.
      
      Original PR: #12346
      Jira URL: https://ixsystems.atlassian.net/browse/NAS-124687
      445ea28e
    • Andrew Walker's avatar
      Fix selecting parameters with NULL value in filter_list (#12348) · 97ead65d
      Andrew Walker authored
      Select logic was broken for case where the parameter we were selecting
      had a null value. This fixes the behavior and adds test.
      97ead65d
  4. 17 Oct, 2023 3 commits
    • mgrimesix's avatar
      NAS-124684 / 24.04 / Move krb5 ccache directory from /tmp (#12343) · 574ab000
      mgrimesix authored
      * Move default krb5cc from /tmp to /var/run/middleware
      * On every boot systemd cleans /tmp directory.  This randomly results
        in deleting a newly generated system krb5cc_0
      
      The fix is to move the 'default' location for the credential cache.
      The path is middleware.utils.MIDDLEARE_RUN_DIR = /var/run/middleware
      
      Updated the SYSTEM and USER krb5ccache
      Updated krb5.conf.mako to configure kerberos to use the new path
      
      * Add modification to krb5 stub file
      Prepend 'FILE:' to ccache path
      
      * Convert the stub from hard-coded parms to use the values from KRB_LibDefaults.
      Small flake8 cleanup to runtest.py
      574ab000
    • Andrew Walker's avatar
      Add validator for CTDB private IP addresses (#12341) · df8ffee4
      Andrew Walker authored
      Force RFC-1918 addresses for inter-node traffic on TrueNAS
      clusters.
      df8ffee4
    • Waqar Ahmed's avatar
      Reduce the time to check if truecommand connection is active · 438b2eed
      Waqar Ahmed authored
      This commit adds changes to reduce the time to check if truecommand connection is active to 30 seconds instead of 30 minutes after setting up the interfaces and everything because the latter was way too long and system only updated the status before if truecommand.config was explicitly called. Setting it to 30 seconds works nicely and is enough to ensure the relevant wireguard interface is up and everything.
      438b2eed
  5. 16 Oct, 2023 2 commits
    • Andrew Walker's avatar
      Add share_type preset for mixed SMB/NFS (#12332) · de1385d6
      Andrew Walker authored
      In principle in Linux this is less of a problem than in FreeBSD
      because of proper inotify support, and kernel oplocks. Add a
      share_type preset that provides user with dataset settings that
      are likely to make SMB and NFS clients happier.
      de1385d6
    • Andrew Walker's avatar
      Fix filtering behavior for user and group queries (#12333) · a57de49b
      Andrew Walker authored
      This commit removes a legacy behavior for the private method
      dscache.query. In this case dscache.query calls would also retrieve the
      local users datastore and return unified results. This was due to
      some design constraints when replacing the user and group cache in our
      legacy django webui in TrueNAS 11.2. As of SCALE the webui no longer
      directly calls dscache.query to get user / group lists and so we can
      safely remove this oddity.
      
      The primary motivation for removing this legacy behavior is to fix
      how query-options are applied to query results.
      a57de49b
  6. 15 Oct, 2023 1 commit
    • Andrew Walker's avatar
      NAS-124557 / 24.04 / Allow nsupdate to set non-private IP addresses (#12281) · 8e0a62fb
      Andrew Walker authored
      This commit includes two principle changes:
      1) the nsupdate endpoint now allows GLOBAL addresses
      2) validation for IP addresses to register happens earlier in
      activedirectory.update so that we can raise proper validation error
      and redirect user to either disable the automatic DNS update or fix
      the server configuration prior to joining AD. As things stand, this
      can cause an exception mid-join and leave server in semi-deployed
      state.
      
      Future enhancement will be to allow users to select which addresses
      to register in DNS. At that point, we can safely allow global
      addresses.
      8e0a62fb
  7. 14 Oct, 2023 18 commits