Merge pull request #5520 from truenas/NAS-110827-2

NAS-110827 / 21.08 / NAS-110827 - Enabling max-len linter rule

.eslintrc.js

@@ -32,9 +32,15 @@ module.exports = {
         "no-return-assign": "off",
         "no-empty": ["error", { "allowEmptyCatch": true }],
         "arrow-body-style": "off",
+        "max-len": ["error", 170, 2, {
+          "ignoreUrls": true,
+          "ignoreComments": false,
+          "ignoreRegExpLiterals": true,
+          "ignoreStrings": true,
+          "ignoreTemplateLiterals": true
+        }],
 
         // TODO: Aibnb rules that are disabled for now as they cannot be fixed automatically
-        "max-len": "off",
         "no-underscore-dangle": "off",
         "@typescript-eslint/naming-convention": "off",
         "class-methods-use-this": "off",

src/app/pages/applications/dialogs/catalog-summary/catalog-summary-dialog.component.ts

@@ -35,7 +35,13 @@ export class CatalogSummaryDialog implements OnInit {
     this.filteredVersions = {};
     Object.keys(this.catalogApp.versions).forEach((key) => {
       const version = this.catalogApp.versions[key];
-      if (this.selectedStatus == this.statusOptions[0] || this.selectedStatus == this.statusOptions[1] && version.healthy || this.selectedStatus == this.statusOptions[2] && !version.healthy) {
+      if (
+        this.selectedStatus == this.statusOptions[0]
+        || this.selectedStatus == this.statusOptions[1]
+        && version.healthy
+        || this.selectedStatus == this.statusOptions[2]
+        && !version.healthy
+      ) {
         this.filteredVersions[key] = version;
       }
     });

src/app/pages/common/entity/entity-form/components/tooltip/tooltip.component.ts

@@ -92,11 +92,11 @@ export class TooltipComponent {
       card = formParent;
     } else if (formParent.offsetParent && formParent.offsetParent.tagName.toLowerCase() == 'mat-card') {
       card = formParent.offsetParent;
-    } else if (formParent.offsetParent.offsetParent && formParent.offsetParent.offsetParent.tagName.toLowerCase() == 'mat-card') {
+    } else if (formParent.offsetParent.offsetParent?.tagName.toLowerCase() == 'mat-card') {
       card = formParent.offsetParent.offsetParent;
-    } else if (formParent.offsetParent.offsetParent.offsetParent && formParent.offsetParent.offsetParent.offsetParent.tagName.toLowerCase() == 'mat-card') {
+    } else if (formParent.offsetParent.offsetParent.offsetParent?.tagName.toLowerCase() == 'mat-card') {
       card = formParent.offsetParent.offsetParent.offsetParent;
-    } else if (formParent.offsetParent.offsetParent.offsetParent.offsetParent && formParent.offsetParent.offsetParent.offsetParent.offsetParent.tagName.toLowerCase() == 'mat-card') {
+    } else if (formParent.offsetParent.offsetParent.offsetParent.offsetParent?.tagName.toLowerCase() == 'mat-card') {
       card = formParent.offsetParent.offsetParent.offsetParent.offsetParent;
     }
     this.isSlideInForm = card.parentNode.classList.value.includes('slidein-entity-form');

src/app/pages/common/entity/entity-tree-table/entity-tree-table.component.ts

@@ -197,7 +197,8 @@ export class EntityTreeTableComponent implements OnInit, AfterViewInit {
   isTableOverflow(): boolean {
     let hasHorizontalScrollbar = false;
     if (this.table) {
-      hasHorizontalScrollbar = this.table._elementRef.nativeElement.parentNode.parentNode.scrollWidth > this.table._elementRef.nativeElement.parentNode.parentNode.clientWidth;
+      const parentNode = this.table._elementRef.nativeElement.parentNode;
+      hasHorizontalScrollbar = parentNode.parentNode.scrollWidth > parentNode.parentNode.clientWidth;
     }
     return hasHorizontalScrollbar;
   }

src/app/pages/credentials/backup-credentials/forms/cloud-credentials-form.component.ts

@@ -1522,7 +1522,9 @@ export class CloudCredentialsFormComponent implements FormConfiguration {
         field_name += '-' + provider;
       }
       if (entityForm.formGroup.controls[field_name]) {
-        entityForm.formGroup.controls[field_name].setValue(field_name == 'auth_version-OPENSTACK_SWIFT' ? entityForm.wsResponseIdx[i].toString() : entityForm.wsResponseIdx[i]);
+        entityForm.formGroup.controls[field_name].setValue(field_name == 'auth_version-OPENSTACK_SWIFT'
+          ? entityForm.wsResponseIdx[i].toString()
+          : entityForm.wsResponseIdx[i]);
       }
     }
   }

src/app/pages/credentials/backup-credentials/forms/ssh-connections-form.component.ts

@@ -311,7 +311,9 @@ export class SshConnectionsFormComponent implements FormConfiguration {
   }
 
   isManualAuthFormValid(): boolean {
-    return this.entityForm.formGroup.controls['host'].valid && this.entityForm.formGroup.controls['private_key'].valid && this.entityForm.formGroup.controls['username'].valid;
+    return this.entityForm.formGroup.controls['host'].valid
+      && this.entityForm.formGroup.controls['private_key'].valid
+      && this.entityForm.formGroup.controls['username'].valid;
   }
 
   setDisabled(fieldConfig: any, fieldName: string, disable: boolean, hide = false): void {

src/app/pages/data-protection/replication/replication-wizard/replication-wizard.component.ts

@@ -799,7 +799,11 @@ export class ReplicationWizardComponent {
       (res: ReplicationTask[]) => {
         for (const task of res) {
           if (task.transport !== TransportMode.Legacy) {
-            const lable = task.name + ' (' + ((task.state && task.state.datetime) ? 'last run ' + this.datePipe.transform(new Date(task.state.datetime.$date), 'MM/dd/yyyy') : 'never ran') + ')';
+            // TODO: Change to icu message format.
+            const lable = task.name + ' (' + ((task.state && task.state.datetime)
+              ? 'last run ' + this.datePipe.transform(new Date(task.state.datetime.$date), 'MM/dd/yyyy')
+              : 'never ran')
+            + ')';
             exist_replicationField.options.push({ label: lable, value: task });
             if (this.pk === task.id) {
               this.loadOrClearReplicationTask(task);
@@ -909,8 +913,13 @@ export class ReplicationWizardComponent {
   step1Init(): void {
     this.entityWizard.formArray.controls[1].controls['retention_policy'].valueChanges.subscribe((value: any) => {
       const disable = value === RetentionPolicy.Source;
-      disable ? this.entityWizard.formArray.controls[1].controls['lifetime_value'].disable() : this.entityWizard.formArray.controls[1].controls['lifetime_value'].enable();
-      disable ? this.entityWizard.formArray.controls[1].controls['lifetime_unit'].disable() : this.entityWizard.formArray.controls[1].controls['lifetime_unit'].enable();
+      if (disable) {
+        this.entityWizard.formArray.controls[1].controls['lifetime_value'].disable();
+        this.entityWizard.formArray.controls[1].controls['lifetime_unit'].disable();
+      } else {
+        this.entityWizard.formArray.controls[1].controls['lifetime_value'].enable();
+        this.entityWizard.formArray.controls[1].controls['lifetime_unit'].enable();
+      }
     });
   }
 
@@ -985,7 +994,16 @@ export class ReplicationWizardComponent {
       task['ssh_credentials_source'] = task.ssh_credentials.id;
     }
 
-    for (const i of ['source_datasets_from', 'target_dataset_from', 'ssh_credentials_source', 'ssh_credentials_target', 'transport', 'source_datasets', 'target_dataset']) {
+    const controls = [
+      'source_datasets_from',
+      'target_dataset_from',
+      'ssh_credentials_source',
+      'ssh_credentials_target',
+      'transport',
+      'source_datasets',
+      'target_dataset',
+    ];
+    for (const i of controls) {
       const ctrl = this.entityWizard.formArray.controls[0].controls[i];
       if (ctrl && !ctrl.disabled) {
         ctrl.setValue(task[i]);
@@ -1131,7 +1149,11 @@ export class ReplicationWizardComponent {
       };
       if (payload.encryption) {
         payload['encryption_key_format'] = data['encryption_key_format'];
-        payload['encryption_key'] = data['encryption_key_format'] === EncryptionKeyFormat.Passphrase ? data['encryption_key_passphrase'] : (data['encryption_key_generate'] ? this.replicationService.generateEncryptionHexKey(64) : data['encryption_key_hex']);
+        payload['encryption_key'] = data['encryption_key_format'] === EncryptionKeyFormat.Passphrase
+          ? data['encryption_key_passphrase']
+          : (data['encryption_key_generate']
+            ? this.replicationService.generateEncryptionHexKey(64)
+            : data['encryption_key_hex']);
         payload['encryption_key_location'] = data['encryption_key_location_truenasdb'] ? '$TrueNAS' : data['encryption_key_location'];
       }
 
@@ -1366,14 +1388,18 @@ export class ReplicationWizardComponent {
   }
 
   getSnapshots(): void {
-    let transport = this.entityWizard.formArray.controls[0].controls['transport'].enabled ? this.entityWizard.formArray.controls[0].controls['transport'].value : TransportMode.Local;
+    let transport = this.entityWizard.formArray.controls[0].controls['transport'].enabled
+      ? this.entityWizard.formArray.controls[0].controls['transport'].value
+      : TransportMode.Local;
     // count local snapshots if transport is SSH/SSH-NETCAT, and direction is PUSH
     if (this.entityWizard.formArray.controls[0].controls['ssh_credentials_target'].value) {
       transport = TransportMode.Local;
     }
     const payload = [
       this.entityWizard.formArray.controls[0].controls['source_datasets'].value || [],
-      (this.entityWizard.formArray.controls[0].controls['naming_schema'].enabled && this.entityWizard.formArray.controls[0].controls['naming_schema'].value) ? this.entityWizard.formArray.controls[0].controls['naming_schema'].value.split(' ') : [this.defaultNamingSchema],
+      (this.entityWizard.formArray.controls[0].controls['naming_schema'].enabled && this.entityWizard.formArray.controls[0].controls['naming_schema'].value)
+        ? this.entityWizard.formArray.controls[0].controls['naming_schema'].value.split(' ')
+        : [this.defaultNamingSchema],
       transport,
       transport === TransportMode.Local ? null : this.entityWizard.formArray.controls[0].controls['ssh_credentials_source'].value,
     ];

src/app/pages/jails/jail-form/jail-form.service.ts

@@ -246,7 +246,15 @@ export class JailFormService {
         for (let i = 0; i < value[propName].length; i++) {
           const subAddr = value[propName][i];
           if (subAddr[propName] != '' && subAddr[propName] != undefined) {
-            multi_ipaddr.push(this.getFullIP(ipType, subAddr[ipType + '_interface'], subAddr[propName], subAddr[ipType + (ipType == 'ip4' ? '_netmask' : '_prefix')], ip4_interfaceField, ip6_interfaceField));
+            const ip = this.getFullIP(
+              ipType,
+              subAddr[ipType + '_interface'],
+              subAddr[propName],
+              subAddr[ipType + (ipType == 'ip4' ? '_netmask' : '_prefix')],
+              ip4_interfaceField,
+              ip6_interfaceField,
+            );
+            multi_ipaddr.push(ip);
           }
         }
         value[propName] = multi_ipaddr.join(',');

src/app/pages/network/forms/configuration.component.ts

@@ -143,9 +143,23 @@ export class ConfigurationComponent implements FormConfiguration {
           name: 'outbound_network_activity',
           placeholder: '',
           options: [
-            { label: helptext.outbound_network_activity.allow.placeholder, value: 'DENY', tooltip: helptext.outbound_network_activity.allow.tooltip }, // deny type + empty list
-            { label: helptext.outbound_network_activity.deny.placeholder, value: 'ALLOW', tooltip: helptext.outbound_network_activity.deny.tooltip }, // allow type + empty list
-            { label: helptext.outbound_network_activity.specific.placeholder, value: 'SPECIFIC', tooltip: helptext.outbound_network_activity.specific.tooltip },
+            // deny type + empty list
+            {
+              label: helptext.outbound_network_activity.allow.placeholder,
+              value: 'DENY',
+              tooltip: helptext.outbound_network_activity.allow.tooltip,
+            },
+            // allow type + empty list
+            {
+              label: helptext.outbound_network_activity.deny.placeholder,
+              value: 'ALLOW',
+              tooltip: helptext.outbound_network_activity.deny.tooltip,
+            },
+            {
+              label: helptext.outbound_network_activity.specific.placeholder,
+              value: 'SPECIFIC',
+              tooltip: helptext.outbound_network_activity.specific.tooltip,
+            },
           ],
           value: 'DENY',
         },

src/app/pages/network/network.component.ts

@@ -171,7 +171,9 @@ export class NetworkComponent extends ViewControllerComponent implements OnInit,
     afterGetData() {
       const state = this.parent.navigation.extras.state as { configureOpenVPN: string };
       if (state && state.configureOpenVPN) {
-        state.configureOpenVPN === 'client' ? this.parent.modalService.open('slide-in-form', this.parent.openvpnClientComponent) : this.parent.modalService.open('slide-in-form', this.parent.openvpnServerComponent);
+        state.configureOpenVPN === 'client'
+          ? this.parent.modalService.open('slide-in-form', this.parent.openvpnClientComponent)
+          : this.parent.modalService.open('slide-in-form', this.parent.openvpnServerComponent);
       }
     },
   };

src/app/pages/reportsdashboard/reportsdashboard.component.ts

@@ -399,7 +399,9 @@ export class ReportsDashboardComponent implements OnInit, OnDestroy, /* HandleCh
             name: 'metrics',
             width: 'calc(50% - 16px)',
             placeholder: T('Choose a metric'),
-            options: this.diskMetrics ? this.diskMetrics : [{ label: 'None available', value: 'negative' }], // eg. [{label:'temperature',value:'temperature'},{label:'operations', value:'disk_ops'}],
+
+            // eg. [{label:'temperature',value:'temperature'},{label:'operations', value:'disk_ops'}],
+            options: this.diskMetrics ? this.diskMetrics : [{ label: 'None available', value: 'negative' }],
             required: true,
             multiple: true,
             tooltip: T('Choose a metric to display.'),

src/app/pages/services/components/service-ftp/service-ftp.component.ts

@@ -421,7 +421,13 @@ export class ServiceFTPComponent implements FormConfiguration, OnInit {
     this.rootlogin_fg = entityEdit.formGroup.controls['rootlogin'];
     this.rootloginSubscription = this.rootlogin_fg.valueChanges.subscribe((res: any) => {
       if (res && !this.warned && !this.rootlogin) {
-        this.dialog.confirm(helptext.rootlogin_dialog_title, helptext.rootlogin_dialog_message, false, T('Continue'), false, '', null, {}, null, false, T('Cancel'), true).subscribe((confirm: any) => {
+        this.dialog.confirm({
+          title: helptext.rootlogin_dialog_title,
+          message: helptext.rootlogin_dialog_message,
+          buttonMsg: T('Continue'),
+          cancelMsg: T('Cancel'),
+          disableClose: true,
+        }).subscribe((confirm) => {
           if (!confirm) {
             this.rootlogin_fg.setValue(false);
           } else {

src/app/pages/sharing/iscsi/target/target-form/target-form.component.ts

@@ -196,7 +196,10 @@ export class TargetFormComponent implements FormConfiguration {
         (initiatorsRes) => {
           initiatorGroupField.options.push({ label: 'None', value: null });
           for (let i = 0; i < initiatorsRes.length; i++) {
-            const optionLabel = initiatorsRes[i].id + ' (' + (initiatorsRes[i].initiators.length === 0 ? 'ALL Initiators Allowed' : initiatorsRes[i].initiators.toString()) + ')';
+            const optionLabel = initiatorsRes[i].id
+              + ' ('
+              + (initiatorsRes[i].initiators.length === 0 ? 'ALL Initiators Allowed' : initiatorsRes[i].initiators.toString())
+              + ')';
             initiatorGroupField.options.push({ label: optionLabel, value: initiatorsRes[i].id });
           }
           resolve(true);

src/app/pages/sharing/iscsi/target/target-list/target-list.component.ts

@@ -64,7 +64,11 @@ export class TargetListComponent implements OnInit {
   }
 
   doAdd(rowId: string = null): void {
-    this.modalService.open('slide-in-form', new TargetFormComponent(this.router, this.aroute, this.iscsiService, this.loader, this.translate, this.ws, this.modalService), rowId);
+    this.modalService.open(
+      'slide-in-form',
+      new TargetFormComponent(this.router, this.aroute, this.iscsiService, this.loader, this.translate, this.ws, this.modalService),
+      rowId,
+    );
     this.modalService.onClose$.subscribe(() => {
       this.entityList.getData();
     });

src/app/pages/storage/volumes/volumes-list/volumes-list.component.ts

@@ -1559,7 +1559,10 @@ export class VolumesListTableConfig implements InputTableConf {
                     body['pbkdf2iters'] = formValue.pbkdf2iters;
                   }
                   payload.push(body);
-                  const dialogRef = self.mdDialog.open(EntityJobComponent, { data: { title: helptext.encryption_options_dialog.save_encryption_options }, disableClose: true });
+                  const dialogRef = self.mdDialog.open(EntityJobComponent, {
+                    data: { title: helptext.encryption_options_dialog.save_encryption_options },
+                    disableClose: true,
+                  });
                   dialogRef.componentInstance.setDescription(helptext.encryption_options_dialog.saving_encryption_options);
                   dialogRef.componentInstance.setCall(method, payload);
                   dialogRef.componentInstance.submit();
@@ -1787,7 +1790,22 @@ export class VolumesListTableConfig implements InputTableConf {
 export class VolumesListComponent extends EntityTableComponent implements OnInit, OnDestroy {
   title = T('Pools');
   zfsPoolRows: ZfsPoolData[] = [];
-  conf: InputTableConf = new VolumesListTableConfig(this, this.router, '', [], this.mdDialog, this.ws, this.dialogService, this.loader, this.translate, this.storage, {}, this.messageService, this.http, this.validationService);
+  conf: InputTableConf = new VolumesListTableConfig(
+    this,
+    this.router,
+    '',
+    [],
+    this.mdDialog,
+    this.ws,
+    this.dialogService,
+    this.loader,
+    this.translate,
+    this.storage,
+    {},
+    this.messageService,
+    this.http,
+    this.validationService,
+  );
 
   actionComponent = {
     getActions: (row: Pool) => {
@@ -1810,7 +1828,22 @@ export class VolumesListComponent extends EntityTableComponent implements OnInit
 
       return actions;
     },
-    conf: new VolumesListTableConfig(this, this.router, '', [], this.mdDialog, this.ws, this.dialogService, this.loader, this.translate, this.storage, {}, this.messageService, this.http, this.validationService),
+    conf: new VolumesListTableConfig(
+      this,
+      this.router,
+      '',
+      [],
+      this.mdDialog,
+      this.ws,
+      this.dialogService,
+      this.loader,
+      this.translate,
+      this.storage,
+      {},
+      this.messageService,
+      this.http,
+      this.validationService,
+    ),
   };
 
   expanded = false;
@@ -1860,11 +1893,27 @@ export class VolumesListComponent extends EntityTableComponent implements OnInit
 
   readonly PoolStatus = PoolStatus;
 
-  constructor(protected core: CoreService, protected rest: RestService, protected router: Router, protected ws: WebSocketService,
-    protected _eRef: ElementRef, protected dialogService: DialogService, protected loader: AppLoaderService,
-    protected mdDialog: MatDialog, protected erdService: ErdService, protected translate: TranslateService,
-    public sorter: StorageService, protected job: JobService, protected storage: StorageService, protected pref: PreferencesService,
-    protected messageService: MessageService, protected http: HttpClient, modalService: ModalService, public tableService: EntityTableService, protected validationService: ValidationService) {
+  constructor(
+    protected core: CoreService,
+    protected rest: RestService,
+    protected router: Router,
+    protected ws: WebSocketService,
+    protected _eRef: ElementRef,
+    protected dialogService: DialogService,
+    protected loader: AppLoaderService,
+    protected mdDialog: MatDialog,
+    protected erdService: ErdService,
+    protected translate: TranslateService,
+    public sorter: StorageService,
+    protected job: JobService,
+    protected storage: StorageService,
+    protected pref: PreferencesService,
+    protected messageService: MessageService,
+    protected http: HttpClient,
+    modalService: ModalService,
+    public tableService: EntityTableService,
+    protected validationService: ValidationService,
+  ) {
     super(core, rest, router, ws, _eRef, dialogService, loader, erdService, translate, sorter, job, pref, mdDialog, modalService, tableService);
 
     this.actionsConfig = { actionType: VolumesListControlsComponent, actionConfig: this };
@@ -1928,7 +1977,22 @@ export class VolumesListComponent extends EntityTableComponent implements OnInit
           }
           pool.children = pChild ? [pChild] : [];
 
-          pool.volumesListTableConfig = new VolumesListTableConfig(this, this.router, pool.id, datasets, this.mdDialog, this.ws, this.dialogService, this.loader, this.translate, this.storage, pool, this.messageService, this.http, this.validationService);
+          pool.volumesListTableConfig = new VolumesListTableConfig(
+            this,
+            this.router,
+            pool.id,
+            datasets,
+            this.mdDialog,
+            this.ws,
+            this.dialogService,
+            this.loader,
+            this.translate,
+            this.storage,
+            pool,
+            this.messageService,
+            this.http,
+            this.validationService,
+          );
           pool.type = 'zpool';
 
           if (pool.children && pool.children[0]) {

src/app/pages/system/failover/failover.component.ts

@@ -145,7 +145,13 @@ export class FailoverComponent implements FormConfiguration, OnDestroy {
     this.master_fg = this.entityForm.formGroup.controls['master'];
     this.masterSubscription = this.master_fg.valueChanges.subscribe((res: any) => {
       if (!res && !this.warned) {
-        this.dialog.confirm(helptext_system_failover.master_dialog_title, helptext_system_failover.master_dialog_warning, false, T('Continue'), false, '', null, {}, null, false, T('Cancel'), true).subscribe((confirm: boolean) => {
+        this.dialog.confirm({
+          title: helptext_system_failover.master_dialog_title,
+          message: helptext_system_failover.master_dialog_warning,
+          buttonMsg: T('Continue'),
+          cancelMsg: T('Cancel'),
+          disableClose: true,
+        }).subscribe((confirm) => {
           if (!confirm) {
             this.master_fg.setValue(true);
           } else {

src/app/pages/system/update/update.component.ts

@@ -633,7 +633,9 @@ export class UpdateComponent implements OnInit, OnDestroy {
         this.router.navigate([this.router.url + '/manualupdate']);
         break;
       case 'applyPending':
-        const message = this.isHA ? 'The standby controller will be automatically restarted to finalize the update. Apply updates and restart the standby controller?' : 'The system will reboot and be briefly unavailable while applying updates. Apply updates and reboot?';
+        const message = this.isHA
+          ? 'The standby controller will be automatically restarted to finalize the update. Apply updates and restart the standby controller?'
+          : 'The system will reboot and be briefly unavailable while applying updates. Apply updates and reboot?';
         this.dialogService.confirm(
           T('Apply Pending Updates'), T(message),
         ).subscribe((res: boolean) => {

src/app/pages/system/viewenclosure/enclosure-disks/enclosure-disks.component.ts

@@ -289,8 +289,10 @@ export class EnclosureDisksComponent implements AfterContentInit, OnChanges, OnD
   ngOnChanges(changes: SimpleChanges): void {
     if (changes.selectedEnclosure) {
       // Enabled subenclosure functionality
-      this.subenclosure = changes.selectedEnclosure.currentValue.enclosureKey == this.system.headIndex && this.system.rearIndex ? changes.selectedEnclosure.currentValue : undefined;
-      this.loadEnclosure(changes.selectedEnclosure.currentValue, EnclosureLocation.Front);
+      this.subenclosure = this.selectedEnclosure.enclosureKey == this.system.headIndex && this.system.rearIndex
+        ? this.selectedEnclosure
+        : undefined;
+      this.loadEnclosure(this.selectedEnclosure, EnclosureLocation.Front);
     }
   }
 
@@ -773,7 +775,9 @@ export class EnclosureDisksComponent implements AfterContentInit, OnChanges, OnD
     }
 
     // Also check slot status
-    const elements: any[] = this.system.rearIndex && disk.enclosure.number == this.system.rearIndex ? this.system.enclosures[disk.enclosure.number].elements : this.system.enclosures[disk.enclosure.number].elements[0].elements;
+    const elements: any[] = this.system.rearIndex && disk.enclosure.number == this.system.rearIndex
+      ? this.system.enclosures[disk.enclosure.number].elements
+      : this.system.enclosures[disk.enclosure.number].elements[0].elements;
     const slot = elements.filter((s: any) => s.slot == disk.enclosure.slot)[0];
 
     if (!failed && slot.fault) {
@@ -812,7 +816,9 @@ export class EnclosureDisksComponent implements AfterContentInit, OnChanges, OnD
       }
 
       // Also check slot status
-      const elements = this.system.rearIndex && disk.enclosure.number == this.system.rearIndex ? this.system.enclosures[disk.enclosure.number].elements : this.system.enclosures[disk.enclosure.number].elements[0].elements;
+      const elements = this.system.rearIndex && disk.enclosure.number == this.system.rearIndex
+        ? this.system.enclosures[disk.enclosure.number].elements
+        : this.system.enclosures[disk.enclosure.number].elements[0].elements;
       const slot = elements.filter((s: any) => s.slot == disk.enclosure.slot);
 
       if (!failed && slot.fault) {

src/app/pages/vm/vm-wizard/vm-wizard.component.ts

@@ -1097,11 +1097,19 @@ export class VMWizardComponent {
               this.ws.call('vm.delete', [vm_res.id, { zvols: false, force: false }]).subscribe(
                 () => {
                   this.loader.close();
-                  this.dialogService.errorReport(T('Error creating VM.'), T('We ran into an error while trying to create the ') + error.device.dtype + ' device.\n' + error.reason, error.trace.formatted);
+                  this.dialogService.errorReport(
+                    T('Error creating VM.'),
+                    T('We ran into an error while trying to create the ') + error.device.dtype + ' device.\n' + error.reason,
+                    error.trace.formatted,
+                  );
                 },
                 (err) => {
                   this.loader.close();
-                  this.dialogService.errorReport(T('Error creating VM.'), T('We ran into an error while trying to create the ') + error.device.dtype + ' device.\n' + error.reason, error.trace.formatted);
+                  this.dialogService.errorReport(
+                    T('Error creating VM.'),
+                    T('We ran into an error while trying to create the ') + error.device.dtype + ' device.\n' + error.reason,
+                    error.trace.formatted,
+                  );
                   new EntityUtils().handleWSError(this, err, this.dialogService);
                 },
               );
@@ -1152,11 +1160,17 @@ export class VMWizardComponent {
               this.ws.call('vm.delete', [vm_res.id, { zvols: false, force: false }]).subscribe(
                 () => {
                   this.loader.close();
-                  this.dialogService.errorReport(T('Error creating VM.'), T('Error while creating the ') + error.device.dtype + ' device.\n' + error.reason, error.trace.formatted);
+                  this.dialogService.errorReport(
+                    T('Error creating VM.'),
+                    T('Error while creating the ') + error.device.dtype + ' device.\n' + error.reason, error.trace.formatted,
+                  );
                 },
                 (err) => {
                   this.loader.close();
-                  this.dialogService.errorReport(T('Error creating VM.'), T('Error while creating the ') + error.device.dtype + ' device.\n' + error.reason, error.trace.formatted);
+                  this.dialogService.errorReport(
+                    T('Error creating VM.'),
+                    T('Error while creating the ') + error.device.dtype + ' device.\n' + error.reason, error.trace.formatted,
+                  );
                   new EntityUtils().handleWSError(this, err, this.dialogService);
                 },
               );