NAS-118801: Removing any (#7265)

src/app/enums/dataset-checksum.enum.ts

-export enum DatasetChecksum {
-  Sha512 = 'SHA512',
-  Edonr = 'EDONR',
-  Fletcher2 = 'FLETCHER2',
-  Fletcher4 = 'FLETCHER4',
-  On = 'ON',
-  Sha256 = 'SHA256',
-  Skein = 'SKEIN',
-}

src/app/interfaces/iscsi.interface.ts

@@ -15,6 +15,7 @@ export type IscsiPortalUpdate = Omit<IscsiPortal, 'id' | 'tag'>;
 
 export interface IscsiInterface {
   ip: string;
+  port: number;
 }
 
 export interface IscsiInitiatorGroup {

src/app/interfaces/job.interface.ts

@@ -9,8 +9,9 @@ export interface Job<R = unknown, A = unknown[]> {
   description: string;
   error: string;
   exc_info: {
-    type: ResponseErrorType | null;
-    extra: Record<string, unknown>;
+    type?: ResponseErrorType | null;
+    extra: string | number | boolean | unknown[] | Record<string, unknown>;
+    repr?: string;
   };
   exception: string;
   id: number;

src/app/modules/entity/entity-form/components/form-select/form-select.component.ts

@@ -28,16 +28,16 @@ export class FormSelectComponent implements Field, AfterViewInit, AfterViewCheck
   @ViewChild('field', { static: true }) field: MatFormField;
 
   formReady = false;
-  selected: string;
-  selectedValues: string[] = [];
+  selected: unknown;
+  selectedValues: unknown[] = [];
   selectStates: boolean[] = []; // Collection of checkmark states
   customTriggerValue: string[];
-  private _formValue: string | string[];
+  private _formValue: unknown;
   private entityUtils = new EntityUtils();
-  get formValue(): string | string[] {
+  get formValue(): unknown {
     return this._formValue;
   }
-  set formValue(value: string | string[]) {
+  set formValue(value: unknown) {
     const result = this.config.multiple ? this.selectedValues : this.selected;
     this._formValue = result;
   }
@@ -153,7 +153,7 @@ export class FormSelectComponent implements Field, AfterViewInit, AfterViewCheck
   }
 
   updateValues(): void {
-    const newValues: string[] = [];
+    const newValues: unknown[] = [];
     const triggerValue: string[] = [];
     this.selectStates.forEach((item, index) => {
       if (item) {

src/app/modules/entity/entity-form/entity-form.component.ts

@@ -22,6 +22,7 @@ import { Observable, Subscription } from 'rxjs';
 import { filter } from 'rxjs/operators';
 import { ApiDirectory, ApiParams } from 'app/interfaces/api-directory.interface';
 import { FormConfiguration } from 'app/interfaces/entity-form.interface';
+import { Job } from 'app/interfaces/job.interface';
 import { FieldSets } from 'app/modules/entity/entity-form/classes/field-sets';
 import {
   FieldConfig, FormArrayConfig, FormDictConfig, FormListConfig, FormSelectConfig,
@@ -404,27 +405,27 @@ export class EntityFormComponent implements OnInit, OnDestroy, OnChanges, AfterV
     this.router.navigate(new Array('/').concat(route));
   }
 
-  addCall(body: any): Observable<any> {
-    const payload = [];
+  addCall(body: unknown): Observable<unknown> {
+    const payload: unknown[] = [];
     const call = this.conf.addCall;
     payload.push(body);
 
     if (this.conf.isCreateJob) {
-      return this.ws.job(call, payload);
+      return this.ws.job(call, payload as ApiParams<keyof ApiDirectory>);
     }
-    return this.ws.call(call, payload);
+    return this.ws.call(call, payload as ApiParams<keyof ApiDirectory>);
   }
 
-  editCall(body: any): Observable<any> {
-    const payload = [body];
+  editCall(body: unknown): Observable<unknown> {
+    const payload: unknown[] = [body];
     if (this.pk) {
       payload.unshift(this.pk);
     }
 
     if (this.conf.isEditJob) {
-      return this.ws.job(this.conf.editCall, payload);
+      return this.ws.job(this.conf.editCall, payload as ApiParams<keyof ApiDirectory>);
     }
-    return this.ws.call(this.conf.editCall, payload);
+    return this.ws.call(this.conf.editCall, payload as ApiParams<keyof ApiDirectory>);
   }
 
   onSubmit(event: Event): void {
@@ -483,11 +484,11 @@ export class EntityFormComponent implements OnInit, OnDestroy, OnChanges, AfterV
             this.loader.close();
             this.loaderOpen = false;
 
-            if ((this.conf.isEditJob || this.conf.isCreateJob) && res.error) {
-              if (res.exc_info && res.exc_info.extra) {
-                new EntityUtils().handleWsError(this, res);
+            if ((this.conf.isEditJob || this.conf.isCreateJob) && (res as Job).error) {
+              if ((res as Job).exc_info && (res as Job).exc_info.extra) {
+                new EntityUtils().handleWsError(this, res as Job);
               } else {
-                this.dialog.errorReport('Error', res.error, res.exception);
+                this.dialog.errorReport('Error', (res as Job).error, (res as Job).exception);
               }
             } else {
               if (this.conf.afterSave) {

src/app/modules/entity/entity-form/models/field-config.interface.ts

@@ -197,7 +197,7 @@ export interface FormRadioConfig<P = unknown> extends BaseFieldConfig<P>{
 
 export interface FormRadioOption {
   label: string;
-  value: any;
+  value: unknown;
   hiddenFromDisplay?: boolean;
   tooltip?: string;
 }
@@ -298,7 +298,7 @@ export interface FormReadFileConfig<P = unknown> extends BaseFieldConfig<P> {
  */
 export interface FormInputListConfig<P = unknown> extends BaseFieldConfig<P> {
   type: 'input-list';
-  customEventMethod: (parent: any) => void;
+  customEventMethod: (parent: unknown) => void;
 }
 
 export type FieldConfig<P = unknown> =

src/app/modules/entity/entity-form/models/form-select-option.interface.ts

 export interface FormSelectOption {
   label: string;
-  value: any;
+  value: unknown;
   hiddenFromDisplay?: boolean;
   disable?: boolean;
   disabled?: boolean; // TODO: One of these is a typo.

src/app/modules/entity/entity-table/entity-table-actions/entity-table-actions.component.ts

@@ -10,7 +10,7 @@ import { EntityTableAction } from 'app/modules/entity/entity-table/entity-table.
   templateUrl: './entity-table-actions.component.html',
 })
 export class EntityTableActionsComponent implements OnInit, OnChanges {
-  @Input() entity: EntityTableComponent;
+  @Input() entity: EntityTableComponent<Record<string, unknown>>;
   @Input() row: Record<string, unknown>;
   @Input() iconName = 'more_vert';
   @Input() action: string;

src/app/modules/entity/entity-table/entity-table-add-actions/entity-table-add-actions.component.ts

@@ -17,7 +17,7 @@ import { EntityTableService } from 'app/services/entity-table.service';
 })
 export class EntityTableAddActionsComponent implements OnInit, AfterViewInit {
   @ViewChild('filter', { static: false }) filter: ElementRef;
-  @Input() entity: EntityTableComponent;
+  @Input() entity: EntityTableComponent<Record<string, unknown>>;
   filterValue = '';
 
   actions: EntityTableAction[];

src/app/modules/entity/entity-table/entity-table-row-details/entity-table-row-details.component.ts

@@ -13,7 +13,7 @@ import { TaskService } from 'app/services';
 })
 export class EntityTableRowDetailsComponent implements OnInit, OnChanges {
   @Input() config: Record<string, unknown>;
-  @Input() parent: EntityTableComponent;
+  @Input() parent: EntityTableComponent<Record<string, unknown>>;
 
   columns: EntityTableColumn[] = [];
   actions: EntityTableAction[] = [];

src/app/modules/entity/entity-table/entity-table.component.html

 <ng-template #pageHeader>
   <ix-page-title-header>
-    <ix-entity-table-add-actions [entity]="this"></ix-entity-table-add-actions>
+    <ix-entity-table-add-actions [entity]="asGenericTable(this)"></ix-entity-table-add-actions>
   </ix-page-title-header>
 </ng-template>
 
@@ -217,7 +217,7 @@
               (mouseout)="onHover($event, false)"
             >
               <ix-entity-table-actions
-                [entity]="this"
+                [entity]="asGenericTable(this)"
                 [row]="element"
                 (mouseover)="onHover($event, true)"
                 (mouseout)="onHover($event, false)"
@@ -430,7 +430,7 @@
             >
               <ix-entity-table-row-details
                 [config]="element"
-                [parent]="this"
+                [parent]="asGenericTable(this)"
               ></ix-entity-table-row-details>
             </div>
           </td>

src/app/modules/entity/entity-table/entity-table.component.ts

@@ -40,7 +40,7 @@ import { EntityJobComponent } from 'app/modules/entity/entity-job/entity-job.com
 import {
   EntityTableAction,
   EntityTableColumn, EntityTableColumnProp,
-  EntityTableConfig, EntityTableConfigConfig, EntityTableConfirmDialog,
+  EntityTableConfig, EntityTableConfigConfig, EntityTableConfirmDialog, SomeRow,
 } from 'app/modules/entity/entity-table/entity-table.interface';
 import { EntityUtils } from 'app/modules/entity/utils';
 import { selectJob } from 'app/modules/jobs/store/job.selectors';
@@ -59,12 +59,6 @@ import {
   waitForPreferences,
 } from 'app/store/preferences/preferences.selectors';
 
-interface SomeRow {
-  id?: string | number;
-  multiselect_id?: string | number;
-  [key: string]: any;
-}
-
 @UntilDestroy()
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
@@ -80,9 +74,9 @@ interface SomeRow {
     ]),
   ],
 })
-export class EntityTableComponent<Row extends SomeRow = any> implements OnInit, AfterViewInit, OnDestroy {
+export class EntityTableComponent<Row extends SomeRow = SomeRow> implements OnInit, AfterViewInit, OnDestroy {
   @Input() title = '';
-  @Input() conf: EntityTableConfig;
+  @Input() conf: EntityTableConfig<Row>;
 
   @ViewChild('newEntityTable', { static: false }) entitytable: TemplateRef<void>;
   @ViewChild(MatPaginator, { static: false }) paginator: MatPaginator;
@@ -149,7 +143,7 @@ export class EntityTableComponent<Row extends SomeRow = any> implements OnInit,
   dataSource: MatTableDataSource<Row>;
   rows: Row[] = [];
   currentRows: Row[] = []; // Rows applying filter
-  getFunction: Observable<any>;
+  getFunction: Observable<unknown>;
   config: EntityTableConfigConfig = {
     paging: true,
     sorting: { columns: this.columns },
@@ -712,7 +706,7 @@ export class EntityTableComponent<Row extends SomeRow = any> implements OnInit,
   }
 
   generateRows(res: any): Row[] {
-    let rows: any[];
+    let rows: Row[];
     if (this.loaderOpen) {
       this.loader.close();
       this.loaderOpen = false;
@@ -720,17 +714,17 @@ export class EntityTableComponent<Row extends SomeRow = any> implements OnInit,
 
     if (res.data) {
       if (res.data.result) {
-        rows = new EntityUtils().flattenData(res.data.result);
+        rows = new EntityUtils().flattenData(res.data.result) as Row[];
       } else {
-        rows = new EntityUtils().flattenData(res.data);
+        rows = new EntityUtils().flattenData(res.data) as Row[];
       }
     } else {
-      rows = new EntityUtils().flattenData(res);
+      rows = new EntityUtils().flattenData(res) as Row[];
     }
 
     rows.forEach((row) => {
       Object.keys(row).forEach((attr) => {
-        row[attr] = this.rowValue(row, attr);
+        (row[attr as keyof Row] as unknown) = this.rowValue(row, attr);
       });
     });
 
@@ -740,7 +734,7 @@ export class EntityTableComponent<Row extends SomeRow = any> implements OnInit,
       }
     } else {
       this.currentRows.forEach((row) => {
-        const index = _.findIndex(rows, { id: row.id });
+        const index = _.findIndex(rows, { id: row.id } as _.PartialShallow<Row>);
         if (index > -1) {
           Object.keys(rows[index]).forEach((prop) => {
             row[prop as keyof Row] = rows[index][prop];
@@ -750,7 +744,7 @@ export class EntityTableComponent<Row extends SomeRow = any> implements OnInit,
 
       const newRows: Row[] = [];
       this.rows.forEach((row) => {
-        const index = _.findIndex(rows, { id: row.id });
+        const index = _.findIndex(rows, { id: row.id } as _.PartialShallow<Row>);
         if (index < 0) {
           return;
         }
@@ -789,7 +783,7 @@ export class EntityTableComponent<Row extends SomeRow = any> implements OnInit,
     return [];
   }
 
-  rowValue(row: any, attr: string): unknown {
+  rowValue(row: Record<string, unknown>, attr: string): unknown {
     if (this.conf.rowValue) {
       try {
         return this.conf.rowValue(row, attr);
@@ -1052,10 +1046,11 @@ export class EntityTableComponent<Row extends SomeRow = any> implements OnInit,
 
   // Stores currently selected columns in preference service
   selectColumnsToShowOrHide(): void {
-    const newColumnPreferences: TableDisplayedColumns = {
+    // TODO: Some type here is incorrect
+    const newColumnPreferences = {
       title: this.title,
-      cols: this.conf.columns as any,
-    };
+      cols: this.conf.columns,
+    } as unknown as TableDisplayedColumns;
 
     this.store$.pipe(select(selectPreferencesState), take(1), untilDestroyed(this)).subscribe((state) => {
       if (!state.areLoaded) {
@@ -1241,4 +1236,8 @@ export class EntityTableComponent<Row extends SomeRow = any> implements OnInit,
       this.changeDetectorRef.markForCheck();
     });
   }
+
+  asGenericTable(entity: EntityTableComponent<Row>): EntityTableComponent<Record<string, unknown>> {
+    return entity as EntityTableComponent<Record<string, unknown>>;
+  }
 }

src/app/modules/entity/entity-table/entity-table.interface.ts

@@ -5,7 +5,13 @@ import { ApiMethod } from 'app/interfaces/api-directory.interface';
 import { EmptyConfig, EmptyType } from 'app/modules/entity/entity-empty/entity-empty.component';
 import { EntityTableComponent } from 'app/modules/entity/entity-table/entity-table.component';
 
-export interface EntityTableConfig<Row = unknown> {
+export interface SomeRow {
+  id?: string | number;
+  multiselect_id?: string | number;
+  [key: string]: any;
+}
+
+export interface EntityTableConfig<Row extends SomeRow = SomeRow> {
   columns: EntityTableColumn[];
   title?: string;
 
@@ -14,7 +20,7 @@ export interface EntityTableConfig<Row = unknown> {
   columnFilter?: boolean;
   hideTopActions?: boolean;
   queryCall?: ApiMethod;
-  queryCallOption?: any;
+  queryCallOption?: unknown;
   queryCallJob?: boolean;
   resourceName?: string;
   routeEdit?: string | string[];
@@ -54,29 +60,29 @@ export interface EntityTableConfig<Row = unknown> {
    */
   getCustomEmptyConfig?: (emptyType: EmptyType) => EmptyConfig;
   wsDeleteParams?: (row: Row, id: string | number) => unknown;
-  addRows?: (entity: EntityTableComponent) => void;
-  changeEvent?: (entity: EntityTableComponent) => void;
-  preInit?: (entity: EntityTableComponent) => void;
-  afterInit?: (entity: EntityTableComponent) => void;
-  dataHandler?: (entity: EntityTableComponent) => unknown;
+  addRows?: (entity: EntityTableComponent<Row>) => void;
+  changeEvent?: (entity: EntityTableComponent<Row>) => void;
+  preInit?: (entity: EntityTableComponent<Row>) => void;
+  afterInit?: (entity: EntityTableComponent<Row>) => void;
+  dataHandler?: (entity: EntityTableComponent<Row>) => unknown;
   resourceTransformIncomingRestData?: (data: unknown) => unknown;
   getActions?: (row: Row) => EntityTableAction<Row>[];
-  getAddActions?: () => EntityTableAction[];
+  getAddActions?: () => EntityTableAction<Row>[];
   rowValue?: (row: unknown, attr: string) => unknown;
   wsMultiDeleteParams?: (selected: Row[]) => [string, (string[][] | number[][])?];
-  doAdd?: (id?: string | number, tableComponent?: EntityTableComponent) => void;
-  doEdit?: (id?: string | number, tableComponent?: EntityTableComponent) => void;
+  doAdd?: (id?: string | number, tableComponent?: EntityTableComponent<Row>) => void;
+  doEdit?: (id?: string | number, tableComponent?: EntityTableComponent<Row>) => void;
   onCheckboxChange?: (row: Row) => void;
   onSliderChange?: (row: Row) => void;
   onButtonClick?: (row: Row) => void;
-  callGetFunction?: (entity: EntityTableComponent) => void;
-  prerequisiteFailedHandler?: (entity: EntityTableComponent) => void;
+  callGetFunction?: (entity: EntityTableComponent<Row>) => void;
+  prerequisiteFailedHandler?: (entity: EntityTableComponent<Row>) => void;
   afterDelete?(): void;
 
   onRowClick?: (row: Row) => void;
 }
 
-export interface EntityTableAction<Row = unknown> {
+export interface EntityTableAction<Row extends SomeRow = SomeRow> {
   id: string | number;
   // TODO: Either name or actionName may be unnecessary
   name: string;
@@ -87,7 +93,7 @@ export interface EntityTableAction<Row = unknown> {
   onClick: (row?: Row) => void;
   title?: string;
   disabled?: boolean;
-  actions?: EntityTableAction[];
+  actions?: EntityTableAction<Row>[];
   matTooltip?: string;
   ttposition?: TooltipPosition;
 }

src/app/modules/entity/table/table.service.ts

@@ -70,7 +70,7 @@ export class TableService {
       });
   }
 
-  delete(table: TableComponent, item: Record<string, any>, action?: string): void {
+  delete(table: TableComponent, item: Record<string, unknown>, action?: string): void {
     const deleteMsg: string = table.tableConf.confirmDeleteDialog?.isMessageComplete
       ? ''
       : this.getDeleteMessage(table, item, action);

src/app/modules/entity/utils.ts

@@ -9,10 +9,10 @@ import { DialogService } from 'app/services';
 // eslint-disable-next-line @typescript-eslint/naming-convention
 export const NULL_VALUE = 'null_value';
 
-// eslint-disable-next-line @typescript-eslint/ban-types
-export type ItemBeforeFlattening = object & {
+export type ItemBeforeFlattening = {
   id: string | number;
   children?: ItemBeforeFlattening[];
+  [key: string]: unknown;
 };
 
 type DataBeforeFlattening = ItemBeforeFlattening | ItemBeforeFlattening[];

src/app/modules/ix-forms/services/form-error-handler.service.ts

@@ -19,7 +19,7 @@ export class FormErrorHandlerService {
     }
 
     if ('exc_info' in error && error.exc_info.type === ResponseErrorType.Validation && error.exc_info.extra) {
-      this.handleValidationError({ ...error, extra: error.exc_info.extra as any }, formGroup);
+      this.handleValidationError({ ...error, extra: error.exc_info.extra as string[][] }, formGroup);
       return;
     }
 

src/app/pages/applications/manage-catalogs/manage-catalogs.component.ts

@@ -65,7 +65,7 @@ export class ManageCatalogsComponent implements EntityTableConfig<Catalog>, OnIn
   catalogSyncJobIds: number[] = [];
 
   private dialogRef: MatDialogRef<EntityJobComponent>;
-  protected entityList: EntityTableComponent;
+  protected entityList: EntityTableComponent<Catalog>;
 
   constructor(
     private mdDialog: MatDialog,
@@ -113,7 +113,7 @@ export class ManageCatalogsComponent implements EntityTableConfig<Catalog>, OnIn
     }
   }
 
-  afterInit(entityList: EntityTableComponent): void {
+  afterInit(entityList: EntityTableComponent<Catalog>): void {
     this.entityList = entityList;
   }
 

src/app/pages/credentials/certificates-dash/certificates-dash.component.ts

@@ -215,7 +215,7 @@ export class CertificatesDashComponent implements OnInit {
                 hideCancel: true,
               });
             } else {
-              this.tableService.delete(table, row);
+              this.tableService.delete(table, row as unknown as Record<string, unknown>);
             }
           },
         },

src/app/pages/data-protection/cloudsync/cloudsync-list/cloudsync-list.component.ts

@@ -49,7 +49,7 @@ export class CloudsyncListComponent implements EntityTableConfig<CloudSyncTaskUi
   routeAddTooltip = this.translate.instant('Add Cloud Sync Task');
   routeEdit: string[] = ['tasks', 'cloudsync', 'edit'];
   wsDelete = 'cloudsync.delete' as const;
-  entityList: EntityTableComponent;
+  entityList: EntityTableComponent<CloudSyncTaskUi>;
   asyncView = true;
   filterValue = '';
 
@@ -103,7 +103,7 @@ export class CloudsyncListComponent implements EntityTableConfig<CloudSyncTaskUi
     this.filterValue = this.route.snapshot.paramMap.get('dataset') || '';
   }
 
-  afterInit(entityList: EntityTableComponent): void {
+  afterInit(entityList: EntityTableComponent<CloudSyncTaskUi>): void {
     this.entityList = entityList;
     this.slideInService.onClose$.pipe(untilDestroyed(this)).subscribe(() => {
       this.entityList.getData();

src/app/pages/data-protection/replication/replication-form/replication-form.component.ts

@@ -1323,7 +1323,7 @@ export class ReplicationFormComponent implements FormConfiguration {
     this.toggleNamingSchemaOrRegex();
   }
 
-  resourceTransformIncomingRestData(wsResponse: any): any {
+  resourceTransformIncomingRestData(wsResponse: any): unknown {
     this.queryRes = _.cloneDeep(wsResponse);
     wsResponse['source_datasets_PUSH'] = wsResponse['source_datasets'];
     wsResponse['target_dataset_PUSH'] = wsResponse['target_dataset'];