- 25 Apr, 2019 4 commits
-
-
Richard Laager authored
The first sentence of this commit comes from the wiki, and was originally written by: Rich Ercolani <rincebrain@gmail.com> with changes by: Tom Caputi <tcaputi@datto.com> Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641 Closes #8642
-
Richard Laager authored
Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641
-
Richard Laager authored
encryption depends on bookmark_v2. bookmark_v2 depends on bookmarks. Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641
-
Richard Laager authored
This needs to use tabs instead of spaces to display correctly (i.e. with things lined up). Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641
-
- 23 Apr, 2019 1 commit
-
-
Tomohiro Kusumi authored
It should only affect "zpool". Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Richard Laager <rlaager@wiktel.com> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8644
-
- 19 Apr, 2019 4 commits
-
-
Rafael Kitover authored
Detect in autoconf whether `-lintl` and possibly `-liconv` are necessary for translation functions like `gettext()`. The actual autoconf code is just: ``` AM_ICONV AM_GNU_GETTEXT([external]) LIBS="$LIBS $LTLIBINTL $LTLIBICONV" ``` References: https://www.gnu.org/software/gettext/manual/html_node/AM_005fGNU_005fGETTEXT.html https://www.gnu.org/software/gettext/manual/html_node/AM_005fICONV.html The reason to check for `libiconv` and add it separately is that this is sometimes necessary if users are linking statically. The `config/*.m4` files were added by running `gettextize` and removing everything else. The empty file `config/config.rpath` is necessary to avoid an error with some versions of autotools, see: http://ramblingfoo.blogspot.com/2007/07/required-file-configrpath-not-found.html The `config.rpath` copied by `gettextize` does not currently work, there is some kind of missing interaction with `libtool` and it tries to apply `libtool` flags to the compiler. Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Richard Laager <rlaager@wiktel.com> Signed-off-by:
Rafael Kitover <rkitover@gmail.com> Closes #8554
-
Tomohiro Kusumi authored
Unused since 5649246d ("Remove znode move functionality"), and ZNODE_STAT_ADD() will never be needed. Reviewed-by:
Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
George Melikov <mail@gmelikov.ru> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8636
-
Tomohiro Kusumi authored
Reviewed-by:
Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
George Melikov <mail@gmelikov.ru> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8643
-
Tomohiro Kusumi authored
These aren't unused. `flag` in zfs_create() also isn't to indicate large file. Reviewed-by:
Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Richard Laager <rlaager@wiktel.com> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8635
-
- 16 Apr, 2019 15 commits
-
-
Brian Behlendorf authored
Signed-off-by:
Brian Behlendorf <behlendorf1@llnl.gov>
-
cfzhu authored
1. Support QAT when ZFS is root file-system: When ZFS module is loaded before QAT started, the QAT can be started again in post-process, e.g.: echo 0 > /sys/module/zfs/parameters/zfs_qat_compress_disable echo 0 > /sys/module/zfs/parameters/zfs_qat_encrypt_disable echo 0 > /sys/module/zfs/parameters/zfs_qat_checksum_disable 2. Verify alder checksum of the de-compress result 3. Allocate Digest, IV and AAD buffer in physical contiguous memory by QAT_PHYS_CONTIG_ALLOC. 4. Update the documentation for zfs_qat_compress_disable, zfs_qat_checksum_disable, zfs_qat_encrypt_disable. Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Weigang Li <weigang.li@intel.com> Signed-off-by:
Chengfeix Zhu <chengfeix.zhu@intel.com> Closes #8323 Closes #8610
-
Richard Laager authored
This replaces empty for loops with while loops to make the code easier to read. Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reported-by: github.com/dcb314 Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #6681 Closes #6682 Closes #6683 Closes #8623
-
TerraTech authored
Add the 'zfs version' and 'zpool version' subcommands to display the version of the user space utilities and loaded zfs kernel module. For example: $ zfs version zfs-0.8.0-rc3_169_g67e0366b88 zfs-kmod-0.8.0-rc3_169_g67e0366b88 The '-V' and '--version' aliases were added to support the common convention of using 'zfs --version` to obtain the version information. Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Matthew Ahrens <mahrens@delphix.com> Reviewed-by:
Richard Laager <rlaager@wiktel.com> Signed-off-by:
TerraTech <1118433+TerraTech@users.noreply.github.com> Closes #2501 Closes #8567
-
Richard Laager authored
When creating a non-sparse volume, zfs create sets a refreservation. Accordingly, one needs the "refreservation" ability in addition to the "create" ability in order to create a non-sparse volume. Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reported-by: github.com/homerlinux Reported-by:
Matthew Ahrens <mahrens@delphix.com> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8531 Closes #8624
-
Richard Laager authored
zfs.8 correctly said that GRUB did not support them, but zpool-features.5 said that "Booting off pools...is supported." Now, zpool-features.5 discusses GRUB specifically and indicates its lack of support for these features. Also, I have clarified the wording in both places to indicate that the pool feature cannot be used. It's not a filesystem dataset thing, but pool-wide. I described this as "cannot be used". I think technically the feature can be enabled, just not active. However, the effect is essentially the same: you cannot enable those checksum algorithms on any dataset in the pool, so you might as well not enable the feature (which is just pointing a loaded gun at your foot). In the past, an argument could be made that having all the features enabled was useful for simplicity, as long as you didn't activate the GRUB-incompatible features, but that's getting less and less realistic over time. A user can still do that, but we should not encourage that. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8626 Closes #8446
-
Richard Laager authored
GRUB supports large_blocks. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8626
-
Richard Laager authored
Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8626
-
Richard Laager authored
Nobody is going to be bumping SPA_VERSION again, as OpenZFS has moved on to feature flags. Also, there is no requirement to keep GRUB up-to-date, nor has that been happening. The ZPL_VERSION could be bumped, but that would likely be handled in a similar way, by adding filesystem feature flags. In any event, we do not need this comment, and we certainly don't need a reference to the GRUB 0.97 source code in a Solaris tree. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8626
-
Richard Laager authored
The old wording was effectively "You can not use this (except you can)", which just seems confusing. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8626
-
Richard Laager authored
Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8626
-
Richard Laager authored
Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8626
-
Richard Laager authored
On Linux, this is in man section 8, not 1M. Also, there is no fsdb on Linux, so I removed that. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8626
-
Richard Laager authored
This had a mix of command vs subcommand, quoted vs not quoted, and bolded vs. not bolded command names. Also, fix man page sections from 1M (Solaris) to 8 (Linux). Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8626
-
Richard Laager authored
Previously, the "spare" vdev type was described as "A special pseudo-vdev which...". I wanted to eliminate the word "special" from that, now that the allocation_classes feature exists and there is such a thing as a "special vdev". I ended up eliminating almost all instances of the word "special" that are not referencing the allocation_classes feature. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8626
-
- 15 Apr, 2019 2 commits
-
-
Tom Caputi authored
When receiving a raw send stream only reallocated objects whose contents were not freed by the standard indicators should call dmu_free_long_range(). Furthermore, if calling dmu_free_long_range() is required then the objects current block size must be used and not the new block size. Two additional test cases were added to provided realistic test coverage for processing reallocated objects which are part of a raw receive. Reviewed-by:
Olaf Faaland <faaland1@llnl.gov> Signed-off-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Tom Caputi <tcaputi@datto.com> Closes #8528 Closes #8607
-
Richard Laager authored
Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reported-by:
Matthew Ahrens <mahrens@delphix.com> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8563 Closes #8622
-
- 14 Apr, 2019 4 commits
-
-
Tomohiro Kusumi authored
Use (ZFS_IOC_LAST - ZFS_IOC_FIRST) instead of 256. It seems 256 is just a number large enough to hold ioctls at the moment. Using 256 also causes compile-time warning or error on platfoms whose enum zfs_ioc definition differs. Reviewed-by:
Olaf Faaland <faaland1@llnl.gov> Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Igor Kozhukhov <igor@dilos.org> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8598
-
Tomohiro Kusumi authored
It's 81 now. Reviewed-by:
Olaf Faaland <faaland1@llnl.gov> Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Igor Kozhukhov <igor@dilos.org> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8598
-
Richard Elling authored
By default, depending on the version, gcc can reuse the frame pointer register. This is a micro-optimization that might help on some very old x86 processors. However, it also makes dynamic tracing less useful because the stacks cannot be easily observed. This rule change instructs gcc to use the -fno-omit-frame-pointer option when compiling. Reviewed-by:
Olaf Faaland <faaland1@llnl.gov> Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Elling <Richard.Elling@RichardElling.com> Closes #8617
-
Tom Caputi authored
This patch simply up cleans up a nit and corrects an error message issue that were introduced in the Multiple DVA scrub patch. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Tom Caputi <tcaputi@datto.com> Closes #8619
-
- 12 Apr, 2019 3 commits
-
-
Brian Behlendorf authored
When receiving an object to a previously allocated interior slot the new object should be "allocated" by setting DMU_NEW_OBJECT, not "reallocated" with dnode_reallocate(). For resilience verify the slot is free as required in case the stream is malformed. Add a test case to generate more realistic incremental send streams that force reallocation to occur during the receive. Reviewed-by:
Olaf Faaland <faaland1@llnl.gov> Reviewed-by:
Tom Caputi <tcaputi@datto.com> Signed-off-by:
Brian Behlendorf <behlendorf1@llnl.gov> Closes #8067 Closes #8614
-
Brian Behlendorf authored
Fix style issue for 'tx->tx_txg&TXG_MASK'. There should be white space around the '&' character. Split the dnode_reallocate() ASSERT to make it more readable to clearly separate the checks. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Tom Caputi <tcaputi@datto.com> Signed-off-by:
Brian Behlendorf <behlendorf1@llnl.gov> Closes #8606
-
John Wren Kennedy authored
The cleanup function of auto_online_001_pos does not account for the possibility that the test may fail while a disk is still removed. If the test run is using real disks, cleanup should involve restoring any that are missing. Reviewed-by:
Giuseppe Di Natale <guss80@gmail.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
John Kennedy <john.kennedy@delphix.com> Closes #8579
-
- 11 Apr, 2019 1 commit
-
-
Alek P authored
When a system sleeps during a zfs-test, the time spent hibernating is counted against the test's runtime even though the test can't and isn't running. This patch tries to detect timeouts due to hibernation and reruns tests that timed out due to system sleeping. In this version of the patch, the existing behavior of returning non-zero when a test was killed is preserved. With this patch applied we still return nonzero and we also automatically rerun the test we suspect of being killed due to system hibernation. Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed by: John Kennedy <john.kennedy@delphix.com> Signed-off-by:
Alek Pinchuk <apinchuk@datto.com> Closes #8575
-
- 10 Apr, 2019 3 commits
-
-
Jorgen Lundman authored
The error path in zio_crypt_key_unwrap would call zio_crypt_key_destroy which calls rw_destroy(&key->zk_salt_lock); which has not yet been initialized. We move the rw_init() call to the start of zio_crypt_key_unwrap instead. Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Jorgen Lundman <lundman@lundman.net> Closes #8604 Closes #8605
-
Tim Chase authored
The bulk[] array index, count, must be reset per-iteration in order to not overwrite the stack. Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Chris Dunlop <chris@onthe.net.au> Reviewed-by:
Tom Caputi <tcaputi@datto.com> Signed-off-by:
Tim Chase <tim@chase2k.com> Closes #8072 Closes #8597 Closes #8601
-
Tomohiro Kusumi authored
POSIX doesn't define pthread_t as uint_t. It could be a pointer. This code causes below compile error on a platform using pointer for pthread_t. -- kernel.c:815:25: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] (void) printf("%u ", (uint_t)pthread_self()); Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Igor Kozhukhov <igor@dilos.org> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8558
-
- 08 Apr, 2019 3 commits
-
-
Tomohiro Kusumi authored
d1261452 ("Fixes for procfs files backed by linked lists") uses PDE_DATA(), but since PDE_DATA() (public interface which replaced old public interface PDE()) first appeared in upstream kernel 3.10, it lacks visible local definition for kernel < 3.10. Move the local PDE_DATA() definition to a ZoL header, to unbreak build on kernel < 3.10. -- module/spl/spl-procfs-list.c: In function 'procfs_list_open': module/spl/spl-procfs-list.c:166: error: implicit declaration of function 'PDE_DATA' module/spl/spl-procfs-list.c:166: warning: assignment makes pointer from integer without a cast Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
John Gallagher <john.gallagher@delphix.com> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8599
-
Brian Behlendorf authored
Commit df583073 introduced the ability to list the snapshots for a specified dataset. This change inadvertently resulted in only the top- level snapshots being listed when no dataset was specified. Fix this issue by adding an additional check to determine if a dataset was provided to avoid incorrectly restricting the depth. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Alek Pinchuk <apinchuk@datto.com> Signed-off-by:
Brian Behlendorf <behlendorf1@llnl.gov> Closes #8591 Closes #8594
-
Brian Behlendorf authored
The length used for the strlcpy() used the size of zv_value when it should have used the size of zc_name. Correct this typo. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Jorgen Lundman <lundman@lundman.net> Reviewed-by:
Igor Kozhukhov <igor@dilos.org> Signed-off-by:
Brian Behlendorf <behlendorf1@llnl.gov> Closes #8595 Closes #8596
-