- 07 May, 2019 2 commits
-
-
Richard Laager authored
This standardizes the language on "deduplication tables" rather than "dedup data" (which might be read as the data blocks rather than the DDT). Likewise, it standardizes on "small file blocks". It also standardizes on "normal" rather than using both "normal" and "general" in the same paragraph. I also replaced "non-specified" with the more explicit "non-dedup/special". Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8713
-
Antonio Russo authored
Alternative implementation of @rlaager's original modification of zfs-mount-generator fix, with @chrisrd's comments. Set IFS to be only the tab character, matching our `-H` call in `zfs list`, allowing spaces to appear in dataset names (and mountpoints). Also adds comments explaining our rationale. Reviewed-by:
Chris Dunlop <chris@onthe.net.au> Reviewed-by:
Richard Laager <rlaager@wiktel.com> Reviewed-by:
George Melikov <mail@gmelikov.ru> Signed-off-by:
Antonio Russo <antonio.e.russo@gmail.com> Closes #8708 Closes #8718
-
- 06 May, 2019 1 commit
-
-
Richard Laager authored
Authored by: Jason King <jason.king@joyent.com> Reviewed by: Toomas Soome <tsoome@me.com> Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Peter Tribble <peter.tribble@gmail.com> Reviewed by: Gergő Mihály Doma <domag02@gmail.com> Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Approved by: Dan McDonald <danmcd@joyent.com> Ported-by:
Richard Laager <rlaager@wiktel.com> OpenZFS-issue: https://www.illumos.org/issues/10473 OpenZFS-commit: https://github.com/illumos/illumos-gate/commit/736e67003 Closes #8711
-
- 05 May, 2019 1 commit
-
-
Tomohiro Kusumi authored
Drop duplicated phrases in comments. Also drop an obsolete comment "Perform a mount of the associated...", as all it does now is get objid from DMU and lookup incore inode. Reviewed-by:
Giuseppe Di Natale <guss80@gmail.com> Reviewed-by:
Richard Laager <rlaager@wiktel.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8707
-
- 04 May, 2019 2 commits
-
-
Tomohiro Kusumi authored
Linux kernel commit ca79b0c211af63fa3276f0e3fd7dd9ada2439839 "mm: convert totalram_pages and totalhigh_pages variables to atomic" replaced `totalhigh_pages` with an inline function `totalhigh_pages()`. This broke compilation on IA32, etc, as ZoL uses `totalhigh_pages` on archs with highmem. Confirmed on Fedora 30 (5.0.9-301.fc30.i686). Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8677 Closes #8701
-
John Gallagher authored
The kernel function which adds new zvols as disks to the system, add_disk(), briefly opens and closes the zvol as part of its work. Closing a zvol involves waiting for two txgs to sync. This, combined with the fact that the taskq processing new zvols is single threaded, makes this processing new zvols slow. Waiting for these txgs to sync is only necessary if the zvol has been written to, which is not the case during add_disk(). This change adds tracking of whether a zvol has been written to so that we can skip the txg_wait_synced() calls when they are unnecessary. This change also fixes the flags passed to blkdev_get_by_path() by vdev_disk_open() to be FMODE_READ | FMODE_WRITE | FMODE_EXCL instead of just FMODE_EXCL. The flags were being incorrectly calculated because we were using the wrong version of vdev_bdev_mode(). Reviewed-by:
George Wilson <george.wilson@delphix.com> Reviewed-by:
Serapheim Dimitropoulos <serapheim@delphix.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
John Gallagher <john.gallagher@delphix.com> Closes #8526 Closes #8615
-
- 02 May, 2019 5 commits
-
-
JMoVS authored
Users of existing pools, especially pools with top-level encrypted datasets, could run into trouble trying to work around Errata #4. Clarify that removing encrypted snapshots and bookmarks is enough to clear the errata. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Richard Laager <rlaager@wiktel.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Tom Caputi <tcaputi@datto.com> Signed-off-by:
Justin Scholz <git@justinscholz.de> Closes #8682 Closes #8683
-
Matthew Ahrens authored
The comment in lz4_compress_zfs could be more clear and specific. It also contains needlessly strong language. Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Serapheim Dimitropoulos <serapheim@delphix.com> Signed-off-by:
Matthew Ahrens <mahrens@delphix.com> Closes: #8702 Closes: #8703
-
Tom Caputi authored
The 'zpool resilver' command requires that the resilver_defer feature is active on the pool. Unfortunately, the check for this was left out of the original patch. This commit simply corrects this so that the command properly returns an error in this case. Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Igor Kozhukhov <igor@dilos.org> Signed-off-by:
Tom Caputi <tcaputi@datto.com> Closes #8700
-
Tom Caputi authored
Currently, it is possible for the 'zpool scrub' command to progress slightly beyond 100% due to concurrent changes happening on the live pool. This behavior is expected, but the userspace code for 'zpool status' would subtract the expected amount of data from the amount of data already scrubbed, resulting in a negative integer being casted to a large positive one. This number was then used to calculate the estimated completion time, resulting in wildly wrong results. This code changes the behavior so that 'zpool status' does not attempt to report an estimate during this period. Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Igor Kozhukhov <igor@dilos.org> Reviewed-by:
George Melikov <mail@gmelikov.ru> Signed-off-by:
Tom Caputi <tcaputi@datto.com> Closes #8611 Closes #8687
-
Matthew Ahrens authored
This comment seems to misunderstand the ## preprocessor token, which does token concatenation. It is not needed here, since we are concatenating string literals, which is performed by putting the literals next to each other. Additionally, the comment uses offensive language. Reviewed-by:
Igor Kozhukhov <igor@dilos.org> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Tony Nguyen <tony.nguyen@delphix.com> Signed-off-by:
Matthew Ahrens <mahrens@delphix.com> Closes #8698 Closes #8699
-
- 01 May, 2019 3 commits
-
-
Tomohiro Kusumi authored
sigignore(3) isn't portable. This code fails to compile on platforms without sigignore(3). Use sigaction(2). -- zfs_main.c: In function 'zfs_do_diff': zfs_main.c:7178:9: error: implicit declaration of function 'sigignore' [-Werror=implicit-function-declaration] (void) sigignore(SIGPIPE); ^~~~~~~~~ Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8593
-
Tomohiro Kusumi authored
sigset(3) isn't portable. This code fails to compile on platforms without sigset(3). Use sigaction(2). -- largest_file.c: In function 'main': largest_file.c:75:9: error: implicit declaration of function 'sigset'; did you mean 'sigvec'? [-Werror=implicit-function-declaration] (void) sigset(SIGXFSZ, sigxfsz); ^~~~~~ sigvec Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8593
-
Tomohiro Kusumi authored
The size argument of snprintf(3) in glibc and snprintf() in Linux kernel includes trailing \0, as snprintf(3) man page explains it as "write at most size bytes (including the trailing null byte ('\0'))", i.e. snprintf() can just take buffer size. e.g. For snprintf() in module/zfs/zfs_ctldir.c, a buffer size is MAXPATHLEN, and a caller is passing MAXPATHLEN to snprintf(), so size should just be `path_len` to do what the caller is trying to do. Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Richard Laager <rlaager@wiktel.com> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8692
-
- 30 Apr, 2019 3 commits
-
-
Richard Laager authored
Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Tom Caputi <tcaputi@datto.com> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8691
-
Brian Behlendorf authored
Signed-off-by:
Matthew Ahrens <mahrens@delphix.com> Signed-off-by:
Brian Behlendorf <behlendorf1@llnl.gov> Closes #8660
-
Brian Behlendorf authored
Not all block devices, notably scsi_debug, set a root_blkg on the request queue. Remove this assertion and allow the the existing call to blkg_tryget() to gracefully handle the NULL (which it does). Reviewed-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Signed-off-by:
Brian Behlendorf <behlendorf1@llnl.gov> Closes #8678
-
- 26 Apr, 2019 2 commits
-
-
Tomohiro Kusumi authored
Use NV_ENCODE_NATIVE for nvlist encoding variable instead of 0. Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Chris Dunlop <chris@onthe.net.au> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8653
-
Tomohiro Kusumi authored
`make distclean` removes an empty file config/config.rpath. Avoid that by adding some text. Also see e1245d83 ("Prevent `make distclean` removing 0 sized file"). -- # find . -size 0 ./config/config.rpath # ./autogen.sh && ./configure # git diff # make distclean # git diff diff --git a/config/config.rpath b/config/config.rpath deleted file mode 100644 index e69de29bb..000000000 Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8665
-
- 25 Apr, 2019 15 commits
-
-
Tomohiro Kusumi authored
Use either SEEK_* or 0,1,2..., but not both. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8656
-
Tom Caputi authored
This patch fixes 2 issues with the DMU free throttle implemented in dmu_free_long_range(). The first issue is that get_next_chunk() was calculating the number of L1 blocks the free would dirty incorrectly. In some cases involving extremely large files, this code would greatly overestimate the number of effected L1 blocks, causing excessive calls to txg_wait_open(). This patch corrects the calculation. The second issue is that the free throttle uses the total number of free'd blocks in all (open, quiescing, and syncing) txgs to determine whether to throttle. This causes large frees (such as those created by the first issue) to cause 4 txg syncs before any further frees were allowed to proceed. This patch ensures that the accounting is done entirely in a per-txg fashion, so that frees from a given txg don't affect those that immediately follow it. Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Matthew Ahrens <mahrens@delphix.com> Signed-off-by:
Tom Caputi <tcaputi@datto.com> Closes #8655
-
Richard Laager authored
- Remove the language that "all user data" is encrypted. This is to avoid misunderstandings or arguments about what is "user data", especially in light of "user properties". - Document that properties are unencrypted. - Document that snapshot names are unencrypted. - For consistency with the rest of the zfs.8 man page, use "ZFS" as the generic noun, not (bolded) "zfs". The latter refers to the command. Likewise, use "ZFS" instead of "the kernel module". - Give "a passphrase" as an example of a "user's key". Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
George Melikov <mail@gmelikov.ru> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8652
-
Richard Laager authored
This adds the encryption copies=3 limitation language into the copies property section. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8651
-
Richard Laager authored
This documents, in zpool.8, that dedupditto is deprecated and will be made to have no effect in a future release. Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Matthew Ahrens <mahrens@delphix.com> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8650
-
Richard Laager authored
As far as I know and can tell from testing, \fB\fB...\fR\fR is exactly equivalent to \fB...\fR. Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641
-
Richard Laager authored
The features are sorted in the en_US locale, not the C locale. Specifically, that means that bookmark_v2 comes _after_ bookmarks. Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641
-
Richard Laager authored
This command is being used to unindent, so it should be at the end of each block. This is consistent with the other man pages. Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641
-
Richard Laager authored
Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641
-
Richard Laager authored
It is org.open-zfs:large_blocks (plural). Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641
-
Tom Caputi authored
Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641
-
Richard Laager authored
The first sentence of this commit comes from the wiki, and was originally written by: Rich Ercolani <rincebrain@gmail.com> with changes by: Tom Caputi <tcaputi@datto.com> Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641 Closes #8642
-
Richard Laager authored
Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641
-
Richard Laager authored
encryption depends on bookmark_v2. bookmark_v2 depends on bookmarks. Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641
-
Richard Laager authored
This needs to use tabs instead of spaces to display correctly (i.e. with things lined up). Reviewed-by:
Tom Caputi <tcaputi@datto.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Richard Laager <rlaager@wiktel.com> Closes #8641
-
- 23 Apr, 2019 1 commit
-
-
Tomohiro Kusumi authored
It should only affect "zpool". Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Richard Laager <rlaager@wiktel.com> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8644
-
- 19 Apr, 2019 4 commits
-
-
Rafael Kitover authored
Detect in autoconf whether `-lintl` and possibly `-liconv` are necessary for translation functions like `gettext()`. The actual autoconf code is just: ``` AM_ICONV AM_GNU_GETTEXT([external]) LIBS="$LIBS $LTLIBINTL $LTLIBICONV" ``` References: https://www.gnu.org/software/gettext/manual/html_node/AM_005fGNU_005fGETTEXT.html https://www.gnu.org/software/gettext/manual/html_node/AM_005fICONV.html The reason to check for `libiconv` and add it separately is that this is sometimes necessary if users are linking statically. The `config/*.m4` files were added by running `gettextize` and removing everything else. The empty file `config/config.rpath` is necessary to avoid an error with some versions of autotools, see: http://ramblingfoo.blogspot.com/2007/07/required-file-configrpath-not-found.html The `config.rpath` copied by `gettextize` does not currently work, there is some kind of missing interaction with `libtool` and it tries to apply `libtool` flags to the compiler. Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Richard Laager <rlaager@wiktel.com> Signed-off-by:
Rafael Kitover <rkitover@gmail.com> Closes #8554
-
Tomohiro Kusumi authored
Unused since 5649246d ("Remove znode move functionality"), and ZNODE_STAT_ADD() will never be needed. Reviewed-by:
Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
George Melikov <mail@gmelikov.ru> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8636
-
Tomohiro Kusumi authored
Reviewed-by:
Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
George Melikov <mail@gmelikov.ru> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8643
-
Tomohiro Kusumi authored
These aren't unused. `flag` in zfs_create() also isn't to indicate large file. Reviewed-by:
Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
George Melikov <mail@gmelikov.ru> Reviewed-by:
Richard Laager <rlaager@wiktel.com> Signed-off-by:
Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8635
-
- 16 Apr, 2019 1 commit
-
-
Brian Behlendorf authored
Signed-off-by:
Brian Behlendorf <behlendorf1@llnl.gov>
-